[wip] add groups/categories to all "list" settings#5859
Draft
chri-k wants to merge 16 commits intoMeteorDevelopment:masterfrom
Draft
[wip] add groups/categories to all "list" settings#5859chri-k wants to merge 16 commits intoMeteorDevelopment:masterfrom
chri-k wants to merge 16 commits intoMeteorDevelopment:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
breaks addons, currently breaks configs
Type of change
Description
adds user-definable and pre-defined groups of items to "list" settings (which are actually set settings). groups are saved per setting type, and will update the effective value of all settings using them whenever modified.
State
this is not fully implemented. some features are broken. changes made for the purpose of debugging are included. this will break configs. (and config save/load might be broken anyway).
code is in volatile debugging form, and needs to be condensed and cleaned.
Related issues
not enumerated.
likely conflicts with half of all other PRs
How Has This Been Tested?
testing is incomplete; see discord; see added
TODO/XXXcommentsChecklist:
conditions not met