build: refactor build script#6109
Open
Big-Iron-Cheems wants to merge 1 commit intoMeteorDevelopment:masterfrom
Open
build: refactor build script#6109Big-Iron-Cheems wants to merge 1 commit intoMeteorDevelopment:masterfrom
Big-Iron-Cheems wants to merge 1 commit intoMeteorDevelopment:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Updated the build script with suggestions provided by @crosby-moe.
Moved the
javablock out since it's not atask.Used
providers.gradlePropertyfor type safe access (Gradle cache compatible, can be made lazy by usingorElse+getat use site).Related issues
None.
How Has This Been Tested?
Clean builds and running in PrismLauncher.
Checklist: