-
Notifications
You must be signed in to change notification settings - Fork 984
Clarify docs for arm64 packed unwind, RegI=0 RegF>0 #5855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The condition CR=0 isn't correct here; the same about the first store for float registers doing the predecrement for any variant where there are no integer registers stored before the floats - this goes for both CR=0, CR=2 and CR=3.
|
@mstorsjo : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
CC @pmsjt |
|
Learn Build status updates of commit 2008082: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
The replacement is accurate. When the only case where we get Thank you for the fix @mstorsjo . But we might have to finesse this statement a little better. "the decrement" means which decrement? See, in both the For example: Results in So, we should clarify that this pre-decrement is just to cover for the FP/SIMD registers. This is true even for the results in |
The condition CR=0 isn't correct here; the same about the first store for float registers doing the predecrement for any variant where there are no integer registers stored before the floats - this goes for both CR=0, CR=2 and CR=3.