Skip to content

Ticket #5040: Add a left padding to the help dialog#5041

Open
egmontkob wants to merge 2 commits intoMidnightCommander:masterfrom
egmontkob:5040-help-left-margin
Open

Ticket #5040: Add a left padding to the help dialog#5041
egmontkob wants to merge 2 commits intoMidnightCommander:masterfrom
egmontkob:5040-help-left-margin

Conversation

@egmontkob
Copy link
Contributor

Also: Slightly increase the dialog's width to preserve the same wrapping on the opening page.

Proposed changes

Checklist

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@github-actions github-actions bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Mar 3, 2026
@github-actions github-actions bot added this to the Future Releases milestone Mar 3, 2026
@egmontkob egmontkob added area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around and removed prio: medium Has the potential to affect progress needs triage Needs triage by maintainers labels Mar 3, 2026
@egmontkob egmontkob requested review from mc-worker and zyv March 3, 2026 21:29
@egmontkob
Copy link
Contributor Author

This corresponds to the second screenshot in the bug.

(I've had this PR lying around for a few weeks now... finally gotten to submit it :))

Let me know if you support removing the double spaces, I'd be happy to rework accordingly (and keep the original dialog width).

@egmontkob
Copy link
Contributor Author

dd0dd00 – what a nice commit id :)

@zyv
Copy link
Member

zyv commented Mar 6, 2026

This corresponds to the second screenshot in the bug.

(I've had this PR lying around for a few weeks now... finally gotten to submit it :))

Let me know if you support removing the double spaces, I'd be happy to rework accordingly (and keep the original dialog width).

I would very much favor removing the double spaces! Unfortunately, they are used in a lot of places, and quite inconsistently at that :(

@zyv zyv modified the milestones: Future Releases, 4.9.0 Mar 6, 2026
…ll stops

Also fix some other formatting errors.

Signed-off-by: Egmont Koblinger <egmont@gmail.com>
@egmontkob egmontkob force-pushed the 5040-help-left-margin branch from dd0dd00 to 8f80747 Compare March 6, 2026 21:54
@egmontkob
Copy link
Contributor Author

Went with removing double spaces; at least from the English bits of the help pages that aren't generated from the manuals, and also excluding some preformatted bits in the GPL text.

It's funny how, at the default terminal width of 80, the first 5-ish paragraphs of the GPL text were manually stretched using double spaces so that each line ends at the right margin. Except for the first line of the paragraphs which all align differently at the right edge. And it all completely falls apart if the window width is different from 80. Whoever did this gave up after about 5 paragraphs.

Reverted the widening of the help dialog, it's no longer needed.

Signed-off-by: Egmont Koblinger <egmont@gmail.com>
@egmontkob egmontkob force-pushed the 5040-help-left-margin branch from 8f80747 to 86956ef Compare March 6, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around

Development

Successfully merging this pull request may close these issues.

Help window has no left padding

3 participants