This repository was archived by the owner on May 26, 2018. It is now read-only.
Delay initialization of minecraft commands until after mod pre-init#498
Open
yuuka-miya wants to merge 1 commit intoMinecraftForge:masterfrom
yuuka-miya:delaycmds
Open
Delay initialization of minecraft commands until after mod pre-init#498yuuka-miya wants to merge 1 commit intoMinecraftForge:masterfrom yuuka-miya:delaycmds
yuuka-miya wants to merge 1 commit intoMinecraftForge:masterfrom
yuuka-miya:delaycmds
Conversation
Contributor
Author
There was a problem hiding this comment.
Is there an issue? You requested to keep patches small - that is what I did.
Yep, I kinda noopped 95% of the constructor, decided it was just better to cut it into 2 method bodies.
Member
There was a problem hiding this comment.
yes that is horrible fucking code, do better.
Who in their right mind formats their code like that..
As for the rest of the permissions api, it'll get reviewed, last I looked it was sadly incomplete and i've stated that many many times which I don't want to repeat myself. So don't expect this pulled any time soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation PR to allow some features of MinecraftForge/MinecraftForge#1403
This PR delays the initialization of vanilla's commands, from before FML can startup its hooks into minecraft, to after the mod pre-initialization stage.
This will allow time for permission frameworks as specified in Forge pr 1403 to register themselves in the preinit stage, and thus will be available when the API registers permissions for vanilla commands.