[1.21.5] Simplify ModLoader#hasCompletedState#10674
Open
PaintNinja wants to merge 4 commits intoMinecraftForge:1.21.5from
Open
[1.21.5] Simplify ModLoader#hasCompletedState#10674PaintNinja wants to merge 4 commits intoMinecraftForge:1.21.5from
PaintNinja wants to merge 4 commits intoMinecraftForge:1.21.5from
Conversation
PaintNinja
added
Feature
autoforge
bot
added
Triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new variant of ModLoader#hasCompletedState which takes in the state directly, which is less error-prone than a string and avoids having to search for one that matches the given name.
Also includes some minor cleanup to FML internals to reduce allocating lambdas, indirection in string concat internals, redundant collection copying, etc...
Targeting 1.21.5 so as to not affect the 1.21.9 port, but this PR should be able to target 1.20.1 - 1.21.9 inclusive.