New IAdvancedAsyncStorage interface#618
Closed
profet23 wants to merge 2 commits intoMiniProfiler:mainfrom
Closed
Conversation
…nc to utilize a new overload of IAsyncStorage.SetViewedAsync that accepts multiple ids. Adding PostgreSqlStorage implementation that can set multiple profilers as viewed in a single query. Code cleanup. Adding implementation for RemoteAppendExample.cs Proposal for an IAdvancedAsyncStorage interface to facilitate some optional advanced operations.
Author
|
I'd like to make the new IAdvancedAsyncStorage internal here, but I'm honestly not sure how to implement InternalVisibleToAttribute with the dll signatures and build process. Input welcome. |
Member
|
Hey @profet23 sorry I should have been clearer on other PR: it's not an issue, just that it requires a major release. I have no issues rounding up current items and doing a 5.x release (needs testing with .NET 6, etc.). If we split the interface, then downstream implementors may not ever know about another interface and adding new ones indefinitely I don't think is a sound strategy :) I haven't had the time allocation lately to look at these but based on surface: let's stick with your original and version appropriately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking the comments from: #617
In order to not break existing implementations of
IAsyncStorage, this PR proposes the new interfaceIAdvancedAsyncStoragewhich inherits IAsyncStorage and seeks to provide some additional functionality.The idea would be to merge IAsyncStorage and IAdvancedAsyncStorage in a future release.