Only remove the first iteration of backtrace_remove#643
Open
vprigent wants to merge 1 commit intoMiniProfiler:masterfrom
Open
Only remove the first iteration of backtrace_remove#643vprigent wants to merge 1 commit intoMiniProfiler:masterfrom
vprigent wants to merge 1 commit intoMiniProfiler:masterfrom
Conversation
kbrock
approved these changes
Sep 16, 2025
Contributor
kbrock
left a comment
There was a problem hiding this comment.
- This pretty much assumes that the
backtrace_removeis on the left hand side of the file. (think this is a valid assumption) - Wonder if a regexp for
backtrace_removewould meet your needs. - This may be a breaking change for people.
Having said all that, I think this is a great addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our work setup is as follows:
We use docker for our rails app
We store our app within "/portal" in docker.
We also have a few folders called ".../portal/..." within the code which were getting swallowed by gsub.
backtrace_removedefaults to "#{Rails.root}/" and the only other search result for it within Github returned a similar usage but for a gem