Skip to content

fix(SimpleWebTransport): Use Map instead of Array #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrGadget1024 merged 2 commits into from
Mar 26, 2026
+12 −4
Merged

fix(SimpleWebTransport): Use Map instead of Array #4103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7e9c54
fix(SWT): Use Map instead of array
MrGadget1024 Mar 6, 2026
1aaf4f6
remove trailing space
MrGadget1024 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions Assets/Mirror/Transports/SimpleWeb/SimpleWeb/Client/Webgl/plugin/SimpleWeb.jslib
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,28 @@
// this will create a global object
const SimpleWeb =
{
webSockets: [],
webSockets: null, // unity converts Map to {}, so we have to use new at runtime
next: 1,
GetWebSocket: function (index)
{
return SimpleWeb.webSockets[index]
if (SimpleWeb.webSockets)
return SimpleWeb.webSockets.get(index);
else
return null;
},
AddNextSocket: function (webSocket)
{
if (!SimpleWeb.webSockets)
SimpleWeb.webSockets = new Map();
var index = SimpleWeb.next;
SimpleWeb.next++;
SimpleWeb.webSockets[index] = webSocket;
SimpleWeb.webSockets.set(index, webSocket);
return index;
},
RemoveSocket: function (index)
{
SimpleWeb.webSockets[index] = undefined;
if (SimpleWeb.webSockets)
SimpleWeb.webSockets.delete(index);
},
};

Expand Down Expand Up @@ -56,6 +62,8 @@ function Connect(addressPtr, openCallbackPtr, closeCallBackPtr, messageCallbackP
webSocket._incomingDataBufferAlive = false;
// dynCall('vi', closeCallBackPtr, [index]);
{{{ makeDynCall('vi', 'closeCallBackPtr') }}}(index);

SimpleWeb.RemoveSocket(index);
};

webSocket.onmessage = function(event)
Expand Down