-
Notifications
You must be signed in to change notification settings - Fork 1
Add wait skill and AI writing guard #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryThis PR adds a new The main functional addition is Confidence Score: 3/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 2 comments
| for path in root.rglob("*"): | ||
| if not path.is_file(): | ||
| continue | ||
| rel = path.relative_to(root) | ||
| if any(part in SKIP_DIRS for part in rel.parts): | ||
| continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iter_text_files() skips any file whose relative path parts contain a name in SKIP_DIRS. This will also skip user/source directories that happen to share a name with these entries (e.g., a package named cache/, node_modules/, etc.), not just the intended hidden/tooling dirs at repo root. If the intent is to skip only top-level tool directories, this will produce false negatives where em dashes in those directories are never checked.
Also appears in the same function at scripts/check_ai_writing.py:55.
Prompt To Fix With AI
This is a comment left during a code review.
Path: scripts/check_ai_writing.py
Line: 51:56
Comment:
`iter_text_files()` skips any file whose *relative path parts* contain a name in `SKIP_DIRS`. This will also skip user/source directories that happen to share a name with these entries (e.g., a package named `cache/`, `node_modules/`, etc.), not just the intended hidden/tooling dirs at repo root. If the intent is to skip only top-level tool directories, this will produce false negatives where em dashes in those directories are never checked.
Also appears in the same function at `scripts/check_ai_writing.py:55`.
How can I resolve this? If you propose a fix, please make it concise.
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/linter_require_ruff.yaml
Line: 24:26
Comment:
This workflow installs uv via `curl ... | sh` and then hard-codes `$HOME/.cargo/bin` onto PATH. Depending on how `uv` is installed (and future changes to the installer), `uv` may not land in that directory, leading to intermittent "uv: command not found" CI failures. Consider using the installer’s documented install dir output (or `~/.local/bin`) / verifying `uv --version` after install so PATH is correct.
How can I resolve this? If you propose a fix, please make it concise. |
Summary
bash sleep 60commands so CLI timeouts stay under 2 minutesai writingchecker (em dash detection) plus integrate it into Prek pre-commit and the linter workflowCLAUDE.mdTesting
uv run python scripts/check_ai_writing.py