feat: Use pm-implicit with Cuda12.x#298
Open
chezou wants to merge 2 commits intoMobileTeleSystems:mainfrom
Open
feat: Use pm-implicit with Cuda12.x#298chezou wants to merge 2 commits intoMobileTeleSystems:mainfrom
chezou wants to merge 2 commits intoMobileTeleSystems:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 82 +37
Lines 2242 5650 +3408
===========================================
+ Hits 2242 5650 +3408 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2f43838 to
48685ae
Compare
48685ae to
59a82c9
Compare
Contributor
Author
|
@feldlime @blondered Can you review when you have a chance? I confirmed all the implicit tests has been passed with pm-implicit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to use Cuda 12.x for implicit on Python 3.10+ environment by using pm-implicit, forked version of implicit built with CUDA 12.9.
This reduces build time of implicit wheel for Python 3.12 and 3.13 since official implicit distributes wheels until 3.11.
Note that Python 3.9 was EoL on Oct 25, 2025, so that pm-implicit excludes 3.9 support.
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.