Add instance manager to plugin API#2335
Conversation
when accessing the instance game name or directory
| // called; or | ||
| // 3) whatever was given in setGame() | ||
| // | ||
| QString gameName() const; |
There was a problem hiding this comment.
This applies to most method but these should still be const-qualified, just make the relevant fields mutable.
There was a problem hiding this comment.
Wouldn't readFromIni also need to be const-qualified for that to work?
There was a problem hiding this comment.
Doing so should avoid the need to remove all the const-qualifiers from this PR.
There was a problem hiding this comment.
Wouldn't
readFromInialso need to beconst-qualified for that to work?
Yes, that should not be an issue I think. You can make readFromIni private if it's not already btw, should probably be cleaner now.
There was a problem hiding this comment.
Alright. readFromIni is also called from InstanceManagerDialog::updateInstances, but if I change all INI-values to be memoized, that should no longer be necessary
2 participants
Requires ModOrganizer2/modorganizer-uibase#180
Closes #1631