Change IconDelegate::paintIcons to only execute when iconWidth > 0#2362
Open
mick-lue wants to merge 2 commits intoModOrganizer2:masterfrom
Open
Change IconDelegate::paintIcons to only execute when iconWidth > 0#2362mick-lue wants to merge 2 commits intoModOrganizer2:masterfrom
mick-lue wants to merge 2 commits intoModOrganizer2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When too many Content Icons are supposed to render in too little space in the mod table, the code tries to create a pixmap with dimensions 0x0 resulting in a null icon and generating warning messages in the log.
How to reproduce
Fix
Calculate the iconWidth first and then decide if we want to draw icons.
Side effects?
I didn't encounter any unusual behavior and have been using this for a week now.
Content categories still get shown as usual when hovering over the content row of a modlist entry where this code skipped the icon painting.
It also looks the same whether or not null icons get "drawn".
Anything else that needs to be tested?
Edit: I said "category" but I meant "content"
Example:
