Fix DownloadManager, improve some network code#2363
Open
mick-lue wants to merge 5 commits intoModOrganizer2:masterfrom
Open
Fix DownloadManager, improve some network code#2363mick-lue wants to merge 5 commits intoModOrganizer2:masterfrom
mick-lue wants to merge 5 commits intoModOrganizer2:masterfrom
Conversation
qudix
reviewed
Apr 13, 2026
Author
|
This is the last commit to this PR for now. I forgot to bring 2 changes over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issues with downloads getting stuck, not starting, or not correctly updating the download list.
Changes explained
downloadmanager
createFromMetaaboutToUpdate()when not usingupdate(-1)finished()signal from the NetworkReply so we don't miss it on very fast downloads (also check for fast finished downloads afterwards)addNXMDownloadwas ignoring the first statement because of the commagetFileNameFromNetworkReplythat uses the filename from the URL if it contains at least one char for the name and one char for the file extensiondownloadFinishedto make it more consistentwriteDataso it does preliminary checks itself and the caller does not need to handle itnexusinterface
nxmaccessmanager
organizer_en.ts
My testing experience so far
I haven't had stuck downloads for the last 500 or so files. Before that, most files would instantly get stuck as my download folder was already quite full.