Open
Conversation
|
❌ Changes break the MontiVerse
|
added 3 commits
February 6, 2026 17:32
luepges
reviewed
Feb 6, 2026
cdlang/src/main/java/de/monticore/cdgen/cocos/CDAssociationUnique.java
Outdated
Show resolved
Hide resolved
| import java.util.*; | ||
|
|
||
| /** | ||
| * Checks that there are not multiple occurrences of the same association between types |
Contributor
There was a problem hiding this comment.
give an example?
What does "occurrences of the same association " mean?
cdlang/src/main/java/de/monticore/cdgen/cocos/CDAssociationUnique.java
Outdated
Show resolved
Hide resolved
cdlang/src/main/java/de/monticore/cdgen/cocos/CDAssociationUnique.java
Outdated
Show resolved
Hide resolved
cdlang/src/main/java/de/monticore/cdgen/cocos/CDAssociationUniqueInHierarchy.java
Outdated
Show resolved
Hide resolved
| public void testNonOpposedAssocs3() throws IOException { | ||
| String model = "classdiagram DuplicateAssocs {" + " class A; class B;" | ||
| + " association A -> B;" + " association B <- A;" + "}"; | ||
| runTestForErrorCode(model, ERROR_CODE); |
Contributor
There was a problem hiding this comment.
would it make sense to also check for the content of the error message?
Would help making sure the error messages are useful to users of a tool / makes review easier
Contributor
|
Example output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDUniqueAssociationnow allows "duplicate" associations with explicitly opposing navigation directions: e.g., A -> B, A <- B.CDUniqueAssociationandCDUniqueAssociationInHierarchyoutput SourcePosition of the associations