Skip to content

fix: make agent-build.instructions.md visible to agent mode; fix cpp.instructions.md glob whitespace#356

Merged
softhack007 merged 1 commit intomdevfrom
copilot/add-scope-to-ignore-agent-instructions
Apr 5, 2026
Merged

fix: make agent-build.instructions.md visible to agent mode; fix cpp.instructions.md glob whitespace#356
softhack007 merged 1 commit intomdevfrom
copilot/add-scope-to-ignore-agent-instructions

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 5, 2026

Summary

Two small fixes to the GitHub Copilot instruction files:

1. Fix whitespace in cpp.instructions.md applyTo glob

The applyTo front matter had a spurious space before **/*.ino:

# Before
applyTo: "**/*.cpp,**/*.h,**/*.hpp, **/*.ino"

# After
applyTo: "**/*.cpp,**/*.h,**/*.hpp,**/*.ino"

This is now consistent with esp-idf.instructions.md and avoids any risk of parsers failing to match .ino files.

2. Make agent-build-instructions.md visible to agent mode

Renamed .github/agent-build-instructions.md.github/agent-build.instructions.md and added applyTo: "**" front matter.

GitHub Copilot agent mode automatically includes files named *.instructions.md in .github/ that have a valid applyTo front matter. Without the correct naming convention and front matter, the file was referenced in copilot-instructions.md but not automatically surfaced to the agent.

Updated the link in copilot-instructions.md to point to the new filename.

Summary by CodeRabbit

  • Chores
    • Updated internal development and build configuration files.

…instructions.md glob whitespace

Agent-Logs-Url: https://github.com/MoonModules/WLED-MM/sessions/cc079927-b059-4d79-9290-886ef72964c8

Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@softhack007 softhack007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softhack007
Copy link
Copy Markdown
Collaborator

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c5cb787b-db9a-430c-8eb0-709b3a154b75

📥 Commits

Reviewing files that changed from the base of the PR and between 1fce766 and 2ac9346.

📒 Files selected for processing (3)
  • .github/agent-build.instructions.md
  • .github/copilot-instructions.md
  • .github/cpp.instructions.md

📝 Walkthrough

Walkthrough

Three GitHub instruction files receive minor configuration and documentation updates. An AI-assistant instruction file gains YAML front matter metadata, a reference link is corrected for naming consistency, and a glob pattern is reformatted by removing whitespace.

Changes

Cohort / File(s) Summary
GitHub Instruction Files
.github/agent-build.instructions.md, .github/copilot-instructions.md, .github/cpp.instructions.md
YAML front matter added to agent-build instructions; documentation link corrected from agent-build-instructions.md to agent-build.instructions.md; whitespace removed from C++ file glob pattern for consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • netmindz

Poem

🐰 Hops through the .github with glee,
Front matter, links, and spaces to see,
Instructions polished, neat and tight,
For AI companions to do things right!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes both main changes: renaming agent-build-instructions.md with front matter addition and fixing cpp.instructions.md glob whitespace.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copilot/add-scope-to-ignore-agent-instructions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@softhack007 softhack007 merged commit 101cb8b into mdev Apr 5, 2026
35 checks passed
@softhack007 softhack007 deleted the copilot/add-scope-to-ignore-agent-instructions branch April 5, 2026 15:46
softhack007 added a commit to wled/WLED that referenced this pull request Apr 5, 2026
Initial commit based on WLED-MM version
* shorten previous instructions, by removing duplicated information and shortening wording
* move agent instructions into a separate file
* added coding conventions for C++, webUI, CI/CD (based on WLED-MM, needs adjustment for WLED)
* added .coderabbit.yaml so the rabbits picks the same instructions for reviews.

more information:
* MoonModules#353
* MoonModules#354
* MoonModules#356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants