Merged
Conversation
…readback event duration
…sdaq-mu2e into rrivera/cfoSharedRunPlan
Contributor
Author
|
Corresponds with this PR: Mu2e/mu2e-pcie-utils#115 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces “Shared Run Plan” functionality to the CFO front-end interface, along with related utilities/refactors to support run-plan timing calculations and dependency cleanup across the CFO/DTC core.
Changes:
- Add new CFO FE Macros and implementation for Shared Run Plan status/start/stop/join/leave.
- Centralize run-plan event-duration-to-clocks conversion in
CFOandDTCCoreVInterface(and expose FPGA clock constant). - Formatting/cleanup across several headers/sources; move CFO interface dependency from FEInterfaces to the shared core library.
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/program_one_FPGA.tcl | Minor formatting/newline at EOF. |
| tools/program_both_DTCs.tcl | Minor formatting/newline at EOF. |
| tools/boot_from_flash_both_DTCs.tcl | Minor formatting/newline at EOF. |
| otsdaq-mu2e/TablePlugins/DTCInterfaceTable_table.cc | Reformat slow-controls PV path macro definition. |
| otsdaq-mu2e/TablePlugins/DTCInterfaceTable.h | Reformat declarations/indentation. |
| otsdaq-mu2e/RunInfoPlugins/DBRunInfo.h | Reformat declarations and inline method formatting. |
| otsdaq-mu2e/ROCCore/ROCCoreVInterface.h | Reformat interface methods and inline helpers. |
| otsdaq-mu2e/FEInterfaces/ROCPolarFireCoreInterface.h | Reformat interface definitions and enums. |
| otsdaq-mu2e/FEInterfaces/ROCDTCHardwareEmulated.h | Reformat interface declarations. |
| otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc | Macro registration formatting changes; user-facing strings retained/updated. |
| otsdaq-mu2e/FEInterfaces/DTCFrontEndInterface.h | Reformat declarations and member layout. |
| otsdaq-mu2e/FEInterfaces/CMakeLists.txt | Remove direct CFOInterface link from FEInterfaces library. |
| otsdaq-mu2e/FEInterfaces/CFOFrontEndInterfaceImpl.cc | Add Shared Run Plan FE Macros + logic; adjust runplan generation; add config read try/catch. |
| otsdaq-mu2e/FEInterfaces/CFOFrontEndInterface.h | Remove direct CFO includes; add Shared Run Plan helpers/state. |
| otsdaq-mu2e/CFOandDTCCore/CMakeLists.txt | Add CFOInterface as a PUBLIC dependency of the shared core library. |
| otsdaq-mu2e/CFOandDTCCore/CFOandDTCCoreVInterface.h | Include CFO compiler header; add FPGA clock const and duration→clocks helper. |
| otsdaq-mu2e/CFOandDTCCore/CFOandDTCCoreVInterface.cc | Implement duration→clocks helper; formatting updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
eflumerf
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.