Skip to content

CFO shared run plan checkpoint#255

Merged
rrivera747 merged 21 commits intodevelopfrom
rrivera/cfoSharedRunPlan
Feb 26, 2026
Merged

CFO shared run plan checkpoint#255
rrivera747 merged 21 commits intodevelopfrom
rrivera/cfoSharedRunPlan

Conversation

@rrivera747
Copy link
Copy Markdown
Contributor

No description provided.

@rrivera747
Copy link
Copy Markdown
Contributor Author

Corresponds with this PR: Mu2e/mu2e-pcie-utils#115

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces “Shared Run Plan” functionality to the CFO front-end interface, along with related utilities/refactors to support run-plan timing calculations and dependency cleanup across the CFO/DTC core.

Changes:

  • Add new CFO FE Macros and implementation for Shared Run Plan status/start/stop/join/leave.
  • Centralize run-plan event-duration-to-clocks conversion in CFOandDTCCoreVInterface (and expose FPGA clock constant).
  • Formatting/cleanup across several headers/sources; move CFO interface dependency from FEInterfaces to the shared core library.

Reviewed changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
tools/program_one_FPGA.tcl Minor formatting/newline at EOF.
tools/program_both_DTCs.tcl Minor formatting/newline at EOF.
tools/boot_from_flash_both_DTCs.tcl Minor formatting/newline at EOF.
otsdaq-mu2e/TablePlugins/DTCInterfaceTable_table.cc Reformat slow-controls PV path macro definition.
otsdaq-mu2e/TablePlugins/DTCInterfaceTable.h Reformat declarations/indentation.
otsdaq-mu2e/RunInfoPlugins/DBRunInfo.h Reformat declarations and inline method formatting.
otsdaq-mu2e/ROCCore/ROCCoreVInterface.h Reformat interface methods and inline helpers.
otsdaq-mu2e/FEInterfaces/ROCPolarFireCoreInterface.h Reformat interface definitions and enums.
otsdaq-mu2e/FEInterfaces/ROCDTCHardwareEmulated.h Reformat interface declarations.
otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc Macro registration formatting changes; user-facing strings retained/updated.
otsdaq-mu2e/FEInterfaces/DTCFrontEndInterface.h Reformat declarations and member layout.
otsdaq-mu2e/FEInterfaces/CMakeLists.txt Remove direct CFOInterface link from FEInterfaces library.
otsdaq-mu2e/FEInterfaces/CFOFrontEndInterfaceImpl.cc Add Shared Run Plan FE Macros + logic; adjust runplan generation; add config read try/catch.
otsdaq-mu2e/FEInterfaces/CFOFrontEndInterface.h Remove direct CFO includes; add Shared Run Plan helpers/state.
otsdaq-mu2e/CFOandDTCCore/CMakeLists.txt Add CFOInterface as a PUBLIC dependency of the shared core library.
otsdaq-mu2e/CFOandDTCCore/CFOandDTCCoreVInterface.h Include CFO compiler header; add FPGA clock const and duration→clocks helper.
otsdaq-mu2e/CFOandDTCCore/CFOandDTCCoreVInterface.cc Implement duration→clocks helper; formatting updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread otsdaq-mu2e/FEInterfaces/CFOFrontEndInterfaceImpl.cc
Comment thread otsdaq-mu2e/CFOandDTCCore/CFOandDTCCoreVInterface.cc Outdated
Comment thread otsdaq-mu2e/FEInterfaces/CFOFrontEndInterface.h Outdated
Comment thread otsdaq-mu2e/FEInterfaces/CFOFrontEndInterfaceImpl.cc
Comment thread otsdaq-mu2e/FEInterfaces/CFOFrontEndInterfaceImpl.cc Outdated
Comment thread otsdaq-mu2e/FEInterfaces/CFOFrontEndInterfaceImpl.cc
Comment thread otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc Outdated
Comment thread otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc Outdated
rrivera747 and others added 6 commits February 25, 2026 13:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rrivera747 rrivera747 merged commit 0c0ac4a into develop Feb 26, 2026
6 of 8 checks passed
@rrivera747 rrivera747 deleted the rrivera/cfoSharedRunPlan branch February 26, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants