Adds more information to parse corresponding to the satellite cue fix pr in MPD repository#100
Open
datasone wants to merge 2 commits intoMusicPlayerDaemon:masterfrom
Open
Adds more information to parse corresponding to the satellite cue fix pr in MPD repository#100datasone wants to merge 2 commits intoMusicPlayerDaemon:masterfrom
datasone wants to merge 2 commits intoMusicPlayerDaemon:masterfrom
Conversation
CUE virtual playlists is currently implemented by accessing ranges in file referenced by `real_uri`. But the `real_uri` is not included in the song info protocol now, thus `ProxyDatabasePlugin` is not able to retreive this information and access the corresponding file, leads to not working cue tracks in satellite setup. This commit parses the `real_uri` information returned by mpd server with key name `RealUri`, and adds `real_uri` property and `mpd_song_get_real_uri` function for storing and accessing `real_uri`.
Range `start` and `end` values in `mpd_song` is stored in seconds only, which makes range times in `ProxySong` truncated to seconds and leads to precision loss on satellite cue track range times. This commit adds `start_ms` and `end_ms` properties to store range start and end times in milliseconds, and corresponding functions to access them: `mpd_song_get_start_ms`, `mpd_song_get_end_ms`. The values are parsed from float time values returned by mpd server.
Author
|
The commit messages have been reworded for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr provides some required modifications for the pr "Some fixes and enhancements about cue files in satellite setup" in the MPD repository. It adds ability to parse
real_uri,start_msandend_msfrom the server-printed song info.The commits are detailed in the MPD repo pull request.