Skip to content

MCR-3593 REST API SOLR Alternative ID Mapper Issue#2801

Merged
rsteph-de merged 2 commits into2023.06.xfrom
issues/MCR-3593-rest_api_solr_alternative_id_mapper_issue
Mar 10, 2026
Merged

MCR-3593 REST API SOLR Alternative ID Mapper Issue#2801
rsteph-de merged 2 commits into2023.06.xfrom
issues/MCR-3593-rest_api_solr_alternative_id_mapper_issue

Conversation

@golsch
Copy link
Copy Markdown
Member

@golsch golsch commented Feb 2, 2026

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Bugfix-Specific Checks

  • Affected version is listed in the ticket.
  • Minimal code changes were made (no refactoring).
  • This PR truly fixes only the reported bug.
  • No breaking changes are introduced.
  • A relevant test was added (if feasible).

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@golsch golsch requested a review from rsteph-de February 2, 2026 09:56
@rsteph-de
Copy link
Copy Markdown
Member

I've moved each URLDecoding to the top of the code block and re-added the line for removing the extension

Copy link
Copy Markdown
Member

@rsteph-de rsteph-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes discussed with @golsch - both approve!

@rsteph-de rsteph-de merged commit 319c9a7 into 2023.06.x Mar 10, 2026
3 checks passed
@rsteph-de rsteph-de deleted the issues/MCR-3593-rest_api_solr_alternative_id_mapper_issue branch March 10, 2026 17:12
yagee-de added a commit that referenced this pull request Mar 24, 2026
* 2023.06.x:
  MCR-3647 fix error in command: delete from solr index ... of base (#2863)
  MCR-3638 ensure mods:relatedItem is serialized after main metadata
  MCR-3593 REST API SOLR Alternative ID Mapper Issue (#2801)
yagee-de added a commit that referenced this pull request Mar 24, 2026
* 2024.06.x:
  MCR-3647 fix error in command: delete from solr index ... of base (#2863)
  MCR-3638 ensure mods:relatedItem is serialized after main metadata
  MCR-3593 REST API SOLR Alternative ID Mapper Issue (#2801)
yagee-de added a commit that referenced this pull request Mar 24, 2026
* 2025.06.x:
  fix structure overview bugs (#2864)
  MCR-3647 fix error in command: delete from solr index ... of base (#2863)
  MCR-3636 fix tree view collapse (#2849)
  MCR-3638 ensure mods:relatedItem is serialized after main metadata
  MCR-3593 REST API SOLR Alternative ID Mapper Issue (#2801)
yagee-de added a commit that referenced this pull request Mar 24, 2026
* 2025.12.x:
  fix structure overview bugs (#2864)
  MCR-3647 fix error in command: delete from solr index ... of base (#2863)
  MCR-3636 fix tree view collapse (#2849)
  MCR-3638 ensure mods:relatedItem is serialized after main metadata
  MCR-3593 REST API SOLR Alternative ID Mapper Issue (#2801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants