Skip to content

MCR-3633 obtaininstance should use #getSingleInstanceOf when possible#2846

Merged
Mewel merged 8 commits intomainfrom
issues/MCR-3633-obtaininstance_should_use_mcrconfiguration2
Mar 25, 2026
Merged

MCR-3633 obtaininstance should use #getSingleInstanceOf when possible#2846
Mewel merged 8 commits intomainfrom
issues/MCR-3633-obtaininstance_should_use_mcrconfiguration2

Conversation

@golsch
Copy link
Copy Markdown
Member

@golsch golsch commented Mar 3, 2026

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Bugfix-Specific Checks

  • Affected version is listed in the ticket.
  • Minimal code changes were made (no refactoring).
  • This PR truly fixes only the reported bug.
  • No breaking changes are introduced.
  • A relevant test was added (if feasible).

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@golsch golsch requested a review from toKrause March 3, 2026 11:43
@golsch golsch force-pushed the issues/MCR-3633-obtaininstance_should_use_mcrconfiguration2 branch 2 times, most recently from c5e3fbf to bd7b0ca Compare March 3, 2026 13:05
@golsch
Copy link
Copy Markdown
Member Author

golsch commented Mar 3, 2026

Depends on #2796

@golsch golsch force-pushed the issues/MCR-3633-obtaininstance_should_use_mcrconfiguration2 branch 25 times, most recently from 97caf79 to 07083a6 Compare March 6, 2026 12:22
Comment thread mycore-base/src/main/java/org/mycore/resource/MCRResourceResolver.java Outdated
@golsch golsch force-pushed the issues/MCR-3633-obtaininstance_should_use_mcrconfiguration2 branch 6 times, most recently from 98fb056 to f96a703 Compare March 24, 2026 09:48
@golsch golsch marked this pull request as ready for review March 24, 2026 10:15
@golsch golsch requested a review from toKrause March 24, 2026 10:15
Copy link
Copy Markdown
Contributor

@toKrause toKrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is only one small issue.

(Adding the redundant configuration properties shouldn't have been necessary. I already found the issue and will fix it in a PR in the near future.)

@golsch golsch requested a review from toKrause March 25, 2026 10:58
@Mewel Mewel force-pushed the issues/MCR-3633-obtaininstance_should_use_mcrconfiguration2 branch from 063d31d to 8bde3c1 Compare March 25, 2026 13:09
@Mewel Mewel merged commit ed661aa into main Mar 25, 2026
3 checks passed
@Mewel Mewel deleted the issues/MCR-3633-obtaininstance_should_use_mcrconfiguration2 branch March 25, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants