[TASK] Implement Declaration::getArrayRepresentation()#1564
Merged
Conversation
oliverklee
added
testing
|
coverage: 72.927% (+0.2%) from 72.752% — task/array-rep/declaration into main |
JakeQZ
approved these changes
Apr 11, 2026
Comment on lines
+233
to
+237
| 'propertyName' => $this->propertyName, | ||
| // We're using the term "property value" here to match the wording used in the specs: | ||
| // https://www.w3.org/TR/CSS22/syndata.html#declaration | ||
| 'propertyValue' => $this->value, | ||
| 'important' => $this->isImportant, |
Collaborator
There was a problem hiding this comment.
I take all the Git Blame for this possible slight misnomer in the class. I lifted the terminology from MDN which currently still refers to the CSSOM properties for a 'CSS Declaration' as "property name" and "value". Though it does refer to isImportant as "important flag".
I think we are close enough to the mark to avoid confusion, and the official nomenclature may change in future W3C revisions anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1440.