Open
Conversation
NISH1001
requested changes
Feb 13, 2026
Collaborator
|
@iamsims also provide better descirption for PR. |
NISH1001
requested changes
Feb 13, 2026
Collaborator
NISH1001
left a comment
NISH1001
left a comment
There was a problem hiding this comment.
1st pass:
Couple of observations
- You can avoid using
Annotatedto primite types like float, int, str etc and direclty useField(...)level constraints there - Use
loguru - Use base url from env. the comment says env but env is not impleented
- Add tools for 6 PDS APIs: IMG, ODE, OPUS, PDS4, PDS Catalog, and SBN - Add Literal types derived from sde-data-agents resources (without resources) - Validate parity extensively for IMG, ODE, OPUS, PDS4, and PDS Catalog Note: SBN parity validation still TODO
- Move testing instructions to md - Add loading base url from env with defaults - Use loguru for logging - Remove annotated type and use field type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.