Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the /status endpoint by adding version information for both the Biolink Model and NameRes itself, addressing requirements from issue #244. The changes follow the pattern established in the Node Normalization service.
Changes:
- Added BIOLINK_MODEL_TAG environment variable retrieval with associated GitHub URLs
- Added NameRes version detection from openapi.yml via get_app_info()
- Updated both success and error response structures to include new version fields
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Error message should include variables we've already computed. Could be useful. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Improved comment. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds NameRes version and BIOLINK_MODEL_TAG to
/status. Also adds tests for/statusand improves the API documentation.Closes #244.