Complete the FATES-CLM nitrogen coupling#1472
Complete the FATES-CLM nitrogen coupling#1472slevis-lmwg wants to merge 28 commits intoNGEET:mainfrom
Conversation
This renaming of variables corresponds to 116b310cd20f29bf5ca07b1d89f9e812f4e94477
|
From meeting with @rgknox |
|
Ryan's update 2025/12/15: In our meeting 2025/12/16 Ryan offered to change the integer values (1 and 2) to strings. (I made the change from hardwired values to named params in the code.) |
This changes how we regulate root proportions, such that in CNP mode root proportions are not allowed to change while both N and P are supplementing. This was introduced by Bharat Sharma. slevis resolved conflicts: biogeochem/EDPhysiologyMod.F90 main/EDMainMod.F90 main/EDPftvarcon.F90 main/FatesInterfaceMod.F90
JSON formatted parameter files.
namespace changes (WIP)
Co-authored-by: Samuel Levis <slevis@ucar.edu>
restart uptake flux fixes
Land use clearing logic update This update allows the user to select the logic option that defines whether or not to kill vegetation during land use transitions.
|
@glemieux I just added you as the reviewer also on the FATES side. This is the FATES-CN PR that we talked about this morning. |
|
I reviewed and checked all remaining checkboxes, and I have permission to merge. I will ask at tomorrow's CTSM Software meeting whether it's ok for me to merge and tag this PR. |
|
|
Update check for missing values in incoming datasets The land use timeseries and luh x pft mapping data checks have been updated to handle NaN or -999 values for netcdf _FillValues
Updates to the grazing logic This prevents crop and simliar being grazed to death in the off-season
Description:
I started this PR with changes needed in ESCOMP/CTSM#3409.
So far that's just the renaming of
prt_carbon_allom_hyp to fates_c_only
prt_cnp_flex_allom_hyp to fates_cn
The corresponding ESCOMP issue:
ESCOMP/CTSM#3378
Resolves #1454
Reminder to address #1526
Collaborators:
@rgknox
@adrifoster
Expectation of Answer Changes:
I do not expect answers to change as a result of this PR alone; however, I expect answers to change for
fates_parteh_mode = 2as a result of the corresponding ESCOMP PR. So far I have not seen such diffs, while I have seen diffs forfates_parteh_mode = 1.Checklist
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
As posted here, I ran the fates test-suite against the corresponding baseline with satisfactory results
As posted here, I identified the lines of code responsible for the answer changes
In
/glade/derecho/scratch/slevis/tests_0413-123625deI invoked./cs.status.fails | grep -i fatesspwith this result:If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: