Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
This PR updates the regression-tests devcontainer environment to support running Chrome-based regression tests and bumps the Allure tool version, alongside adding a temporary Trivy ignore entry for a gRPC CVE.
Changes:
- Install Google Chrome Stable in the regression_tests devcontainer build.
- Bump
allurefrom2.37.0to2.38.0for the devcontainer. - Add a Trivy ignore entry for
CVE-2026-33186affectinggoogle.golang.org/grpc.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/projects/regression_tests/.devcontainer/scripts/root_install.sh |
Adds apt repo setup and installs google-chrome-stable during image build. |
src/projects/regression_tests/.devcontainer/.tool-versions |
Updates the pinned Allure CLI version for asdf installation. |
src/common/.trivyignore.yaml |
Adds a CVE ignore for specific gRPC-Go package versions with an expiry date. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/projects/regression_tests/.devcontainer/scripts/root_install.sh
Outdated
Show resolved
Hide resolved
src/projects/regression_tests/.devcontainer/scripts/root_install.sh
Outdated
Show resolved
Hide resolved
src/projects/regression_tests/.devcontainer/scripts/root_install.sh
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details