Skip to content

VED-901: Update extended attribute file destination.#1141

Merged
mfjarvis merged 5 commits intomasterfrom
VED-901-update-extended-attributes-destination-prefix
Feb 10, 2026
Merged

VED-901: Update extended attribute file destination.#1141
mfjarvis merged 5 commits intomasterfrom
VED-901-update-extended-attributes-destination-prefix

Conversation

@mfjarvis
Copy link
Copy Markdown
Contributor

@mfjarvis mfjarvis commented Jan 16, 2026

Summary

  • Routine Change

Changes:

  • Update destination S3 bucket for extended attributes files to be the generic S3 submissions bucket in the DSPP Core account.
  • Update KMS key to the key associated with the new destination.
  • Update the prefix to the required value for these files to be processed as extended attributes files.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@mfjarvis mfjarvis marked this pull request as draft January 16, 2026 14:28
@github-actions
Copy link
Copy Markdown
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-901

@mfjarvis mfjarvis force-pushed the VED-901-update-extended-attributes-destination-prefix branch from ac05ba2 to 0227aab Compare January 27, 2026 14:58
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox January 27, 2026 15:40 — with GitHub Actions Inactive
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox January 27, 2026 15:40 — with GitHub Actions Inactive
@mfjarvis mfjarvis changed the title VED-901: Update extended attributes destination prefix. VED-901: Update extended attributes destination. Jan 28, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 9, 2026

@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox February 9, 2026 15:40 — with GitHub Actions Inactive
@mfjarvis mfjarvis marked this pull request as ready for review February 9, 2026 15:41
@mfjarvis mfjarvis changed the title VED-901: Update extended attributes destination. VED-901: Update extended attribute file destination. Feb 9, 2026
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox February 9, 2026 15:43 — with GitHub Actions Inactive
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox February 9, 2026 15:44 — with GitHub Actions Inactive
@mfjarvis mfjarvis merged commit 9c9acef into master Feb 10, 2026
18 checks passed
@mfjarvis mfjarvis deleted the VED-901-update-extended-attributes-destination-prefix branch February 10, 2026 10:07
mfjarvis added a commit that referenced this pull request Feb 11, 2026
* VED-901: Update extended attributes destination prefix.

* VED-901: Update tests.

* VED-901: Upload EA files directly to the S3 submission upload bucket.

* VED-901: Lint tfvars files.
dlzhry2nhs added a commit that referenced this pull request Feb 17, 2026
* VED-1059 Made adjustment to batch queueing logic (#1189)

* Bump @redocly/cli from 2.15.1 to 2.16.0 in the npm-minor-patch group (#1188)

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).


Updates `@redocly/cli` from 2.15.1 to 2.16.0
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.15.1...@redocly/cli@2.16.0)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.16.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* OAS documentation for name field characters (#1190)

* VED-901: Update extended attribute file destination. (#1141)

* VED-901: Update extended attributes destination prefix.

* VED-901: Update tests.

* VED-901: Upload EA files directly to the S3 submission upload bucket.

* VED-901: Lint tfvars files.

* VED-1017: Generate JSON ACK file (#1168)

* init

* log bugfix

* interim: create_json_ack_file. pending new unit test and fixing old ones

* TEMP_ACK_FILE

* update_json_ack_file

* ingestion_start_time

* complete_batch_file_process

* obtain_current_json_ack_content

* cut/paste fix

* mock out get_ingestion_start_time_by_message_id

* fix & test get_ingestion_start_time_by_message_id

* bugfix

* bugfix split()[]

* test_update_ack_file

* test_complete_batch_file_process_json_ack_file II

* code cleanup

* extra mocks

* supplier

* restored move_file

* json ack file unit tests for lambda_handler (part 1)

* archive source file test - to support e2e testing

* remove redundant functions

* bugfix: get message_id from correct place for JSON ack file

* Trigger build

* bug fix: get_ingestion_start_time_by_message_id

* fixed filename in JSON ack file

* fixed filename in JSON ack file II

* supplier

* unit tests

* cleanup

* kick pipeline

* remove duplicate update_audit_table_item() call

* remove duplicate update_audit_table_item() call II

* review changes

* success -> succeeded

* _make_json_ack_file_row

* refactor json_ack_data helper functions

* _generated_date test values

* update_csv_ack_file

* obtain_current_csv_ack_content

* _generated_date comment

* _make_json_ack_data_row

* manual merge of e2e_automation from #1177

* Remove grafana code, dependabot, README references and sonar config (#1193)

* Bump @redocly/cli from 2.16.0 to 2.17.0 in the npm-minor-patch group (#1192)

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).


Updates `@redocly/cli` from 2.16.0 to 2.17.0
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.16.0...@redocly/cli@2.17.0)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.17.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* VED-000 [NOJIRA] Update Python dependencies. (#1196)

* VED-1039 Added the new vaccine types permitted for TPP and Optum (EMIS) (#1200)

* Bump @redocly/cli from 2.17.0 to 2.18.0 in the npm-minor-patch group (#1198)

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).


Updates `@redocly/cli` from 2.17.0 to 2.18.0
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.17.0...@redocly/cli@2.18.0)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.18.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* Bump @redocly/cli from 2.18.0 to 2.18.1 in the npm-minor-patch group (#1208)

* Bump @redocly/cli from 2.18.0 to 2.18.1 in the npm-minor-patch group

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).


Updates `@redocly/cli` from 2.18.0 to 2.18.1
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.18.0...@redocly/cli@2.18.1)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.18.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Trigger build

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* Bump the terraform-minor-patch group across 2 directories with 1 update (#1209)

Bumps the terraform-minor-patch group with 1 update in the /infrastructure/account directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws).
Bumps the terraform-minor-patch group with 1 update in the /infrastructure/instance directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws).


Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

---
updated-dependencies:
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* VED-1038 updated lint issue (#1207)

* updated the smoke tag and add scenarios as required in ticket

* ruff format

* fix the broken tests

* updated lint issue

* Update tests/e2e_automation/features/APITests/update.feature

Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* fix broken test by adding the valid vaccination in pre-condition

* fix lint issue

---------

Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* VED-981 Add base infrastructure for the MNS Publisher feature (#1191)

* VED-981 (Part 2) Add DLQ, redrive policy, and encryption to queues (#1203)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Akinola Olutola <akinola.olutola1@nhs.net>
Co-authored-by: Matt Jarvis <61870561+mfjarvis@users.noreply.github.com>
Co-authored-by: James W. <218585646+JamesW1-NHS@users.noreply.github.com>
Co-authored-by: Ed Hall <239591530+edhall-nhs@users.noreply.github.com>
Co-authored-by: FimranNHS <fatima.imran3@nhs.net>
dlzhry2nhs pushed a commit that referenced this pull request Feb 24, 2026
* VED-901: Update extended attributes destination prefix.

* VED-901: Update tests.

* VED-901: Upload EA files directly to the S3 submission upload bucket.

* VED-901: Lint tfvars files.
dlzhry2nhs added a commit that referenced this pull request Mar 3, 2026
* VED-1059 Made adjustment to batch queueing logic (#1189)

* Bump @redocly/cli from 2.15.1 to 2.16.0 in the npm-minor-patch group (#1188)

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).

Updates `@redocly/cli` from 2.15.1 to 2.16.0
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.15.1...@redocly/cli@2.16.0)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.16.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* OAS documentation for name field characters (#1190)

* VED-901: Update extended attribute file destination. (#1141)

* VED-901: Update extended attributes destination prefix.

* VED-901: Update tests.

* VED-901: Upload EA files directly to the S3 submission upload bucket.

* VED-901: Lint tfvars files.

* VED-1017: Generate JSON ACK file (#1168)

* init

* log bugfix

* interim: create_json_ack_file. pending new unit test and fixing old ones

* TEMP_ACK_FILE

* update_json_ack_file

* ingestion_start_time

* complete_batch_file_process

* obtain_current_json_ack_content

* cut/paste fix

* mock out get_ingestion_start_time_by_message_id

* fix & test get_ingestion_start_time_by_message_id

* bugfix

* bugfix split()[]

* test_update_ack_file

* test_complete_batch_file_process_json_ack_file II

* code cleanup

* extra mocks

* supplier

* restored move_file

* json ack file unit tests for lambda_handler (part 1)

* archive source file test - to support e2e testing

* remove redundant functions

* bugfix: get message_id from correct place for JSON ack file

* Trigger build

* bug fix: get_ingestion_start_time_by_message_id

* fixed filename in JSON ack file

* fixed filename in JSON ack file II

* supplier

* unit tests

* cleanup

* kick pipeline

* remove duplicate update_audit_table_item() call

* remove duplicate update_audit_table_item() call II

* review changes

* success -> succeeded

* _make_json_ack_file_row

* refactor json_ack_data helper functions

* _generated_date test values

* update_csv_ack_file

* obtain_current_csv_ack_content

* _generated_date comment

* _make_json_ack_data_row

* manual merge of e2e_automation from #1177

* Remove grafana code, dependabot, README references and sonar config (#1193)

* Bump @redocly/cli from 2.16.0 to 2.17.0 in the npm-minor-patch group (#1192)

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).

Updates `@redocly/cli` from 2.16.0 to 2.17.0
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.16.0...@redocly/cli@2.17.0)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.17.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* VED-000 [NOJIRA] Update Python dependencies. (#1196)

* VED-1039 Added the new vaccine types permitted for TPP and Optum (EMIS) (#1200)

* Bump @redocly/cli from 2.17.0 to 2.18.0 in the npm-minor-patch group (#1198)

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).

Updates `@redocly/cli` from 2.17.0 to 2.18.0
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.17.0...@redocly/cli@2.18.0)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.18.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* Bump @redocly/cli from 2.18.0 to 2.18.1 in the npm-minor-patch group (#1208)

* Bump @redocly/cli from 2.18.0 to 2.18.1 in the npm-minor-patch group

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).

Updates `@redocly/cli` from 2.18.0 to 2.18.1
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.18.0...@redocly/cli@2.18.1)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.18.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Trigger build

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* Bump the terraform-minor-patch group across 2 directories with 1 update (#1209)

Bumps the terraform-minor-patch group with 1 update in the /infrastructure/account directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws).
Bumps the terraform-minor-patch group with 1 update in the /infrastructure/instance directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws).

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

---
updated-dependencies:
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* VED-1038 updated lint issue (#1207)

* updated the smoke tag and add scenarios as required in ticket

* ruff format

* fix the broken tests

* updated lint issue

* Update tests/e2e_automation/features/APITests/update.feature

Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* fix broken test by adding the valid vaccination in pre-condition

* fix lint issue

---------

Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* VED-981 Add base infrastructure for the MNS Publisher feature (#1191)

* VED-981 (Part 2) Add DLQ, redrive policy, and encryption to queues (#1203)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Akinola Olutola <akinola.olutola1@nhs.net>
Co-authored-by: Matt Jarvis <61870561+mfjarvis@users.noreply.github.com>
Co-authored-by: James W. <218585646+JamesW1-NHS@users.noreply.github.com>
Co-authored-by: Ed Hall <239591530+edhall-nhs@users.noreply.github.com>
Co-authored-by: FimranNHS <fatima.imran3@nhs.net>
dlzhry2nhs pushed a commit that referenced this pull request Mar 9, 2026
* VED-901: Update extended attributes destination prefix.

* VED-901: Update tests.

* VED-901: Upload EA files directly to the S3 submission upload bucket.

* VED-901: Lint tfvars files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants