VED-1017: Generate JSON ACK file - with E2E test changes#1177
VED-1017: Generate JSON ACK file - with E2E test changes#1177JamesW1-NHS wants to merge 111 commits intomasterfrom
Conversation
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-1017 |
dlzhry2nhs
left a comment
There was a problem hiding this comment.
Nice work, has improvements for the overall test suite and tests the new JSON ack functionality nicely.
Adding the new test cases has brought the automation test suite up from 6 mins - 10 mins. Is it worth removing some of the repeated parametrized test cases from the smoke tests and leaving for functional only. Might also be worth dropping 1-2 batch cases so we only test key scenarios, as that can be quite slow. Ideally 5-8 mins for the pipeline tests...but could always look at it in another ticket.
…sation-fhir-api into VED-1017-json-ack-file
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>
|
|
Done in #1168 |



Summary
This one is not to be merged to master. It has unverified commits. Please merge the identical PR #1168 instead.
Acceptance Criteria
A structured JSON ACK is generated when batch processing completes (EOF received / completion confirmed).
The ACK includes:
Conforms to the Design document: https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?pageId=1187373499&spaceKey=Vacc&title=Immunisation%2BFHIR%2BAPI%2B-%2BACK%2BFile%2BManagement#addcomment
Note: I have marked this as a breaking change as it requires changes to the E2E Automation Tests. These are ongoing. This currently builds successfully in master because the tests requiring modification have been temporarily patched.
Note to Testers
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.