Skip to content

[NDR-359] FHIR DELETE endpoint.#1003

Merged
jameslinnell merged 22 commits intomainfrom
NDR-359
Feb 6, 2026
Merged

[NDR-359] FHIR DELETE endpoint.#1003
jameslinnell merged 22 commits intomainfrom
NDR-359

Conversation

@jameslinnell
Copy link
Copy Markdown
Contributor

@jameslinnell jameslinnell commented Jan 20, 2026 •
edited
Loading

Overview

Jira ticket: NDR-359

Description

Adds "soft" Delete functionality to FHIR

Context

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits.
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

matthewpotter2-nhs
matthewpotter2-nhs reviewed Feb 5, 2026
View reviewed changes
Comment thread lambdas/services/delete_fhir_document_reference_service.py Outdated
matthewpotter2-nhs
matthewpotter2-nhs reviewed Feb 5, 2026
View reviewed changes
Comment thread lambdas/services/delete_fhir_document_reference_service.py Outdated
matthewpotter2-nhs
matthewpotter2-nhs reviewed Feb 5, 2026
View reviewed changes
Comment thread lambdas/services/delete_fhir_document_reference_service.py Outdated
matthewpotter2-nhs
matthewpotter2-nhs reviewed Feb 5, 2026
View reviewed changes
Comment thread lambdas/services/delete_fhir_document_reference_service.py
@jameslinnell
[NDR-359] Initial lambda setup
0b9d97d 
[NDR-359] FHIR DELETE

[NDR-359] Undo change

[NDR-359] PDM FHIR Delete handler unit tests

[NDR-359] Add FHIR DELETE logging context

[NDR-359] FHIR DELETE service unit tests.

[NDR-359] All unit tests

[NDR-359] Remove unused variable.

[NDR-359] Fix line that is too long

[NDR-359] Add deploy lambda code for delete FHIR.

[NDR-359] Fix how path and query params are obtained.

[NDR-359] Working e2e test

[NDR-359] More PDM e2e tests

[NDR-359] Validate NHS number

[NDR-359] Final PDM E2E tests

[NDR-359] LG FHIR E2E tests.

[NDR-359] print LG test

[NDR-359] Tests search results

[NDR-359] LG success

[NDR-359] Remove comments

[NDR-359] Get by id after delete test

[NDR-359] LG FHIR failure e2e tests

[NDR-359] ADD API_KEY to tests
@jameslinnell
[NDR-359] Some formatting
6e07638
@jameslinnell
[NDR-359] Remove dup code
1e7246c
@jameslinnell
[NDR-359] Update unit tests for delete fhir
c5adffb
@jameslinnell
[NDR-359] Correct DB name
8fc6cee
@jameslinnell
[NDR-359] Remove comments
0316131
@jameslinnell
[NDR-359] Fix to the deployment from dev container script.
38719d1
@jameslinnell
[NDR-359] Rename skip main var
493d2f7
@jameslinnell
[NDR-359] Fix deployment name lookup
b3a3292
@jameslinnell
[NDR-359] Change how it gets the title of the workflow
3ef7d2c
@jameslinnell
[NDR-359] Remove LG comment
5c2ffd2
@jameslinnell
[NDR-359] Move delete_document_reference helper to conftest
2def17b
@jameslinnell
[NDR-359] Stricter query params for FHIR deletion.
95c895c
@jameslinnell
[NDR-359] L
5db66d5
@jameslinnell
[NDR-359] Update e2e tests
d6b60f3
@jameslinnell
[NDR-359] LG FHIR failure e2e tests
e9b3e00
@jameslinnell
[NDR-359] Allow FHIR in document_deletion_service
0b576e9
@jameslinnell
[NDR-359] Fix unit test
497cf50
@jameslinnell
[NDR-359] test document delete service for FHIR
9d195e4
@jameslinnell
[NDR-359] Sonarcloud clean up
688c339
@jameslinnell
[NDR-359] PR changes
fb13916
@jameslinnell
[NDR-359] Remove pathParameters check
efa6a38
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 6, 2026

Code security issues found

View full details here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 6, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewpotter2-nhs matthewpotter2-nhs matthewpotter2-nhs approved these changes

@megan-bower4 megan-bower4 megan-bower4 approved these changes

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jameslinnell @matthewpotter2-nhs @megan-bower4