Conversation
nhsd-david-wass
force-pushed
the
feature/CCM-12939-Event-Audit-Pipeline
branch
11 times, most recently
from
e4e092c to
96ea6db
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-12939-Event-Audit-Pipeline
branch
7 times, most recently
from
c87371d to
765c212
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-12939-Event-Audit-Pipeline
branch
2 times, most recently
from
6074628 to
065ae92
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-12939-Event-Audit-Pipeline
branch
from
b52dff8 to
0d248b4
Compare
| @@ -1,4 +1,4 @@ | |||
| resource "aws_kinesis_firehose_delivery_stream" "main" { | |||
| resource "aws_kinesis_firehose_delivery_stream" "eventsub" { | |||
There was a problem hiding this comment.
We need to be a little careful about renaming things, since Terraform's default behaviour is to tear down the old resource and create the new one. That could be disruptive now that we have real data going through production. It might be safer to add a moved block tying the old name to the new name, so that Terraform knows to rename rather than destroy and recreate
| resources = [ | ||
| module.eventsub.sns_topic.arn | ||
| ] | ||
| } |
There was a problem hiding this comment.
I'm curious about where this change came from - it matches a change on an unmerged branch of mine, but I'm not sure it's needed on this branch
There was a problem hiding this comment.
It may have just been me trying to get things to appear in the correct place.
I'll remove it from here and check everything works
nhsd-david-wass
force-pushed
the
feature/CCM-12939-Event-Audit-Pipeline
branch
from
4256d27 to
2f2bc2c
Compare
| @@ -0,0 +1,51 @@ | |||
| resource "aws_s3_bucket_policy" "eventcache" { | |||
There was a problem hiding this comment.
isn't eventcache bucket created via the shared module? I think that module creats a bucket policy already, you can pass additional statements to this var: policy_documents
| @@ -0,0 +1,48 @@ | |||
| resource "aws_s3_bucket_policy" "eventcache" { | |||
There was a problem hiding this comment.
Same here, if we are creating a bucket with the sharedmodules module, then we should be passing these via the variable set, rather than recreating it
3 participants
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.