Skip to content

Fix for PR#86#97

Open
rickomax wants to merge 3 commits intoNLua:mainfrom
rickomax:main
Open

Fix for PR#86#97
rickomax wants to merge 3 commits intoNLua:mainfrom
rickomax:main

Conversation

@rickomax
Copy link
Copy Markdown

@rickomax rickomax commented Apr 8, 2026

Added support for selectively loading Lua standard libraries using luaL_requiref, instead of relying solely on luaL_openlibs.

Added support for selectively loading Lua standard libraries using luaL_requiref, instead of relying solely on luaL_openlibs.
@rickomax
Copy link
Copy Markdown
Author

rickomax commented Apr 8, 2026

Just to clarify, this is not really a “fix,” but rather a simplification of the code in PR #86, which sounds very useful, as the OP mentions. Otherwise, one would have to recompile KeraLua just to add these methods, or even replicate all the P/Invoke mechanics in the calling project just to use the new methods.

@viniciusjarina
Copy link
Copy Markdown
Member

LGTM. I would just revert the whitespace change unrelated to the change

Removed extra line
@rickomax
Copy link
Copy Markdown
Author

rickomax commented Apr 8, 2026

LGTM. I would just revert the whitespace change unrelated to the change

Alright. It looks like the original file had mixed CR/LF line endings, so I’ve standardized everything to LF only.

OpenUTF8 method name normalization
Copy link
Copy Markdown
Author

@rickomax rickomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the extra line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants