build: add dynamic git-versioning, drop rc0, migrate to setuptools#485
Merged
build: add dynamic git-versioning, drop rc0, migrate to setuptools#485
Conversation
- nemo_run/package_info.py: replace packaging.version.Version with MAJOR/MINOR/PATCH/PRE_RELEASE pattern; append +<short-sha> to __version__ at import time via git binary (NO_VCS_VERSION=1 to opt out) - pyproject.toml: switch build backend from hatchling to setuptools, use dynamic version from nemo_run.package_info.__version__, remove packaging runtime dep (no longer needed) - build-test-publish-wheel.yml: pin FW-CI-templates to commit with NO_VCS_VERSION=1 support; switch packaging input to setuptools Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Regenerate lock file after build backend switch (hatchling → setuptools); bump ibm-cloud-sdk-core 3.18.0 → 3.24.1 to get a pre-built wheel and avoid sdist build failure in fresh CI environments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
packages = ["nemo_run"] only includes the top-level package; use find with include = ["nemo_run*"] to capture all subpackages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
thomasdhc
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nemo_run/package_info.py: replacepackaging.version.Versionparsing with standardMAJOR/MINOR/PATCH/PRE_RELEASEpattern; droprc0pre-release tag; append+<short-sha>to__version__at import time using only thegitbinary. SetNO_VCS_VERSION=1to opt out.pyproject.toml: migrate build backend fromhatchling/hatch-vcstosetuptools; use dynamic version fromnemo_run.package_info.__version__; removepackagingfrom runtime deps (no longer needed).build-test-publish-wheel.yml: pin FW-CI-templates to the commit that setsNO_VCS_VERSION=1in the build step env (prevents sdist/wheel version mismatch); switchpackaginginput tosetuptools.Example