fix: include Jinja2 templates in wheel via package-data#486
Merged
Conversation
The templates/ directories have no __init__.py so setuptools packages.find omits them. Add package-data glob to include all .j2 files under nemo_run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
force-pushed
the
ko3n1g/build/dynamic-git-versioning
branch
from
dba33b1 to
8adb91d
Compare
thomasdhc
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
templates/directories undernemo_run/core/execution/andnemo_run/run/ray/contain.j2Jinja2 template files but no__init__.py, sosetuptoolspackages.findwas silently omitting them from the wheel[tool.setuptools.package-data]withnemo_run = ["**/*.j2"]to ensure all Jinja2 templates are bundledTest plan
nemo_run/core/execution/templates/*.j2andnemo_run/run/ray/templates/*.j2are present inside it🤖 Generated with Claude Code