Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
nvddr
force-pushed
the
devdeepr/addTimeToUpdate
branch
12 times, most recently
from
f895054 to
eb96738
Compare
Move extension requirements from ITracker to live impls Extension knowledge is an OpenXR live-session concern, not a tracker concern. Remove get_required_extensions() from ITracker and deviceio_trackers. Each LiveXxxTrackerImpl now declares its own static required_extensions(), and LiveDeviceIOFactory aggregates them via dynamic_cast dispatch. DeviceIOSession::get_required_extensions() delegates to the factory.
nvddr
force-pushed
the
devdeepr/addTimeToUpdate
branch
from
eb96738 to
27fed4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.