[fix][5875912] Fix autoquant-autodeploy example#878
Conversation
Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe pull request simplifies LLM initialization in the API server by removing intermediate AutoDeployConfig object creation and replacing it with direct LLM instantiation. The attn_backend parameter is explicitly changed from triton to flashinfer during this refactoring. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@examples/llm_autodeploy/api_server.py`:
- Around line 48-49: The BuildConfig type and the local variable build_config
are now unused dead code; remove the BuildConfig import and delete the two lines
that create and modify build_config (the BuildConfig(...) instantiation and the
assignment to build_config.plugin_config.tokens_per_block) so there are no
unused symbols left (search for BuildConfig and build_config in api_server.py to
locate the exact spots).
🧹 Nitpick comments (1)
examples/llm_autodeploy/api_server.py (1)
147-152:--backendargument appears unused.
args.backendis never referenced after parsing. Onlyargs.compile_backend(line 53) is passed toLLM. If this was previously consumed by the removedAutoDeployConfigpath, consider removing it.#!/bin/bash # Verify that args.backend is not used anywhere in this file rg -n 'args\.backend\b' examples/llm_autodeploy/api_server.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
=======================================
Coverage 73.44% 73.44%
=======================================
Files 197 197
Lines 20657 20657
=======================================
Hits 15172 15172
Misses 5485 5485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
Type of change: Bug fix
Overview: ?
Please check Bug ticket
Usage
# Add a code snippet demonstrating how to use thisTesting
Tested with
Before your PR is "Ready for review"
Additional Information
Summary by CodeRabbit