Skip to content

extract Optuna from nat-core #1812

Draft
afourniernv wants to merge 1 commit intoNVIDIA:developfrom
afourniernv:feat/optuna-extraction-from-core
Draft

extract Optuna from nat-core #1812
afourniernv wants to merge 1 commit intoNVIDIA:developfrom
afourniernv:feat/optuna-extraction-from-core

Conversation

@afourniernv
Copy link
Contributor

  • Remove optuna dependency from nvidia-nat-core; config_optimizer retains it
  • Add SuggestableTrial Protocol to optimizable.py with suggest_categorical, suggest_int, suggest_float methods
  • Update SearchSpace.suggest() to accept SuggestableTrial instead of optuna.Trial
  • Refresh uv.lock across repo to reflect new dependency graph

Optuna is now a required dependency only in nvidia-nat-config-optimizer. Core uses a structural protocol so any trial-like object (including optuna.Trial) works with SearchSpace.suggest().

Description

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

- Add SuggestableTrial Protocol to optimizable.py with suggest_categorical,
  suggest_int, suggest_float methods
- Update SearchSpace.suggest() to accept SuggestableTrial instead of optuna.Trial
- Remove optuna dependency from nvidia-nat-core; config_optimizer retains it
- Refresh uv.lock across repo to reflect new dependency graph

Optuna is now an optional dependency only in nvidia-nat-config-optimizer.
Core uses a structural protocol so any trial-like object (including
optuna.Trial) works with SearchSpace.suggest().

Signed-off-by: afourniernv <afournier@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 18, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6cfff12c-cb61-4163-a546-d7fa0a1b3b49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@afourniernv afourniernv changed the title refactor(core): extract Optuna from core via SuggestableTrial protocol extract Optuna from core Mar 18, 2026
@afourniernv afourniernv changed the title extract Optuna from core extract Optuna from nat-core Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant