Skip to content

[DO NOT MERGE] Nested ATIF lineage POC for discussion#1814

Draft
AnuradhaKaruppiah wants to merge 12 commits intoNVIDIA:developfrom
AnuradhaKaruppiah:ak-eval-nested-calc
Draft

[DO NOT MERGE] Nested ATIF lineage POC for discussion#1814
AnuradhaKaruppiah wants to merge 12 commits intoNVIDIA:developfrom
AnuradhaKaruppiah:ak-eval-nested-calc

Conversation

@AnuradhaKaruppiah
Copy link
Contributor

Description

This PR shares a nested-lineage POC to align on how we represent and consume execution ancestry in ATIF, with emphasis on canonical tool_calls + Step.extra lineage mapping and upstreamability to AtifStep.

Docs to review in this PR

  • Proposal: packages/nvidia_nat_eval/atif-rich-path-proposal.md
  • Nested/branching eval example: examples/evaluation_and_profiling/simple_calculator_eval/src/nat_simple_calculator_eval/configs/config-branching-nested-trajectory-eval.yml
  • End-to-end example README: examples/evaluation_and_profiling/simple_calculator_eval/README.md

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Introduce a self-contained nested eval path in the simple calculator evaluation
example by registering a power_of_twofunction (which internally calls
calculator__multiply), adding nested eval config/data, and documenting how to runi
nat eval and inspect ATIF function hierarchy output.

Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
…to ATIF

Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
@AnuradhaKaruppiah AnuradhaKaruppiah self-assigned this Mar 19, 2026
@AnuradhaKaruppiah AnuradhaKaruppiah added feature request New feature or request DO NOT MERGE PR should not be merged; see PR for details labels Mar 19, 2026
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 19, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a88ba86c-fd5b-4fdc-b92b-f0c7a801d54c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@afourniernv afourniernv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE PR should not be merged; see PR for details feature request New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants