Skip to content

feat: add allow_no_gpu option to skip GPU requirement during ingest#1668

Merged
jperez999 merged 8 commits intoNVIDIA:mainfrom
tomer-levin-nv:feat/allow-no-gpu-ingest
Mar 24, 2026
Merged

feat: add allow_no_gpu option to skip GPU requirement during ingest#1668
jperez999 merged 8 commits intoNVIDIA:mainfrom
tomer-levin-nv:feat/allow-no-gpu-ingest

Conversation

@tomer-levin-nv
Copy link
Copy Markdown
Collaborator

@tomer-levin-nv tomer-levin-nv commented Mar 20, 2026

Adds an allow_no_gpu flag (default False) to IngestorCreateParams, BatchIngestor, and resolve_requested_plan. When True, skips the "No GPUs available" error and returns a CPU-only RequestedPlan with all GPU allocations set to 0.0.

Made-with: Cursor

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • If adjusting docker-compose.yaml environment variables have you ensured those are mimicked in the Helm values.yaml file.

@tomer-levin-nv tomer-levin-nv requested a review from a team as a code owner March 20, 2026 10:20
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 20, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment thread nemo_retriever/src/nemo_retriever/utils/ray_resource_hueristics.py Outdated
@tomer-levin-nv tomer-levin-nv force-pushed the feat/allow-no-gpu-ingest branch 4 times, most recently from 3d1273d to bd150b2 Compare March 24, 2026 15:46
@tomer-levin-nv tomer-levin-nv requested a review from a team as a code owner March 24, 2026 15:46
@tomer-levin-nv tomer-levin-nv force-pushed the feat/allow-no-gpu-ingest branch 4 times, most recently from 960e69e to c482c32 Compare March 24, 2026 17:02
Adds an allow_no_gpu flag (default False) to IngestorCreateParams,
BatchIngestor, and resolve_requested_plan. When True, skips the
"No GPUs available" error and returns a CPU-only RequestedPlan with
all GPU allocations set to 0.0.

Made-with: Cursor
@tomer-levin-nv tomer-levin-nv force-pushed the feat/allow-no-gpu-ingest branch from c482c32 to 1468415 Compare March 24, 2026 17:04
@jperez999 jperez999 merged commit afe619a into NVIDIA:main Mar 24, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants