Fix deploy nightly docs issue by pggPL · Pull Request #2636 · NVIDIA/TransformerEngine

pggPL · 2026-01-30T19:05:26Z

Description

This PR fixes following issues:

Deploy nightly docs fails, because of non-compatible packages. I tested it in my own fork and version changes fix the issue,

Fixes # (issue)

Type of change

Documentation change (change only to the documentation, either a fix or a new content)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Infra/Build change
Code refactoring

Checklist:

I have read and followed the contributing guidelines
The functionality is complete
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps · 2026-01-30T19:07:48Z

Greptile Summary

This PR fixes the nightly documentation deployment workflow by upgrading GitHub Actions to compatible versions and removing deprecated parameters.

Changes

Upgraded actions/upload-pages-artifact from v1.0.7 to v3
Upgraded actions/deploy-pages from v2.0.0 to v4
Removed deprecated name parameter from upload-pages-artifact (v3 uses fixed name github-pages by default)
Added id: deployment to the deploy step for proper URL output reference in the environment configuration
Added workflow_dispatch trigger to allow manual workflow runs for testing

Impact

The updates ensure compatibility with current GitHub Pages Actions API and resolve the package compatibility issues mentioned in the PR description.

Confidence Score: 5/5

This PR is safe to merge with no risk - it only updates GitHub Actions versions and removes deprecated parameters
The changes are straightforward infrastructure updates that follow GitHub Actions migration guidelines. The upgrade from v1/v2 to v3/v4 is necessary for compatibility, and the removal of the deprecated name parameter is required by v3. The addition of workflow_dispatch and id: deployment are best practices. No code logic is changed, only workflow configuration.
No files require special attention

Important Files Changed

Filename	Overview
.github/workflows/deploy_nightly_docs.yml	Updates GitHub Actions to v3/v4 for compatibility, removes deprecated parameters, and adds manual trigger support

_{Last reviewed commit: 8ac0406}

greptile-apps

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

Restore .github/workflows/build.yml to upstream/main state. Only deploy_nightly_docs.yml changes are relevant to this PR. Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

fix

ee0cca1

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

pggPL changed the title ~~PR to debug github workflows fails~~ PR to debug github workflows failures Jan 30, 2026

greptile-apps Bot reviewed Jan 30, 2026

View reviewed changes

fix

df6a81b

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Jan 30, 2026

View reviewed changes

fix

daa3bf3

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Jan 30, 2026

View reviewed changes

Comment thread .github/workflows/deploy_nightly_docs.yml

pggPL changed the title ~~PR to debug github workflows failures~~ Fix Github workflows issues Jan 30, 2026

fix

d47399a

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Jan 31, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

ccache size limit

d2091f2

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

ccache

4dc9323

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml Outdated

ccache

4171efe

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml Outdated

ccache

b44ec74

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml Outdated

ccache

23ea443

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml Outdated

ccache

a0a528f

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml Outdated

ccache

95c333f

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

pggPL added 2 commits February 3, 2026 04:55

ccache

cb3fa26

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

ccache

cc3c5b1

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

ccache

52f6cb2

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

ccache

4ebbe22

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml

ccache

89d2985

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

ccache

b5f554e

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

ccache

30cd354

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

ccache

ba96b42

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

ccache

7ad602f

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 3, 2026

View reviewed changes

added blackwell

d3bfeeb

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 4, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml Outdated

added blackwell

03488d9

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 4, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml Outdated

Revert build.yml changes unrelated to deploy nightly docs

8ac0406

Restore .github/workflows/build.yml to upstream/main state. Only deploy_nightly_docs.yml changes are relevant to this PR. Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>

greptile-apps Bot reviewed Feb 24, 2026

View reviewed changes

pggPL force-pushed the fix_github_workflows branch from ff94345 to 8ac0406 Compare February 24, 2026 12:24

greptile-apps Bot reviewed Feb 24, 2026

View reviewed changes

pggPL changed the title ~~Fix Github workflows issues~~ Fix deploy nightly docs issue Feb 24, 2026

ptrendx approved these changes Mar 10, 2026

View reviewed changes

ptrendx merged commit 3846bf7 into NVIDIA:main Mar 10, 2026
10 of 12 checks passed

Conversation

pggPL commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist:

Uh oh!

greptile-apps Bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Changes

Impact

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

pggPL commented Jan 30, 2026 •

edited

Loading

greptile-apps Bot commented Jan 30, 2026 •

edited

Loading