Cythonize _program.py #1565
Open
Cythonize _program.py #1565
+928
−862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename _program.py to _program.pyx - Convert Program to cdef class with _program.pxd declarations - Extract _MembersNeededForFinalize to module-level _ProgramMNFF (nested classes not allowed in cdef class) - Add __repr__ method to Program - Keep ProgramOptions as @DataClass (unchanged) - Keep weakref.finalize pattern for handle cleanup
- Move _translate_program_options to Program_translate_options (cdef) - Move _can_load_generated_ptx to Program_can_load_generated_ptx (cdef) - Remove unused TYPE_CHECKING import block - Follow _memory/_buffer.pyx helper function patterns
- Reorganize file structure per developer guide (principal class first) - Add module docstring, __all__, type alias section - Factor long methods into cdef inline helpers - Add proper exception specs to cdef functions - Fix docstrings (use :class: refs, public paths) - Add type annotations to public methods - Inline _nvvm_exception_manager (single use) - Remove Union import, use | syntax - Add public Program.driver_can_load_nvrtc_ptx_output() API - Update tests to use new public API Closes NVIDIA#1082
Andy-Jost
added
P0
Contributor
Contributor
Author
|
/ok to test 85dbbb5 |
|
Andy-Jost
commented
Feb 3, 2026
| mod_obj = ObjectCode.from_ptx(ptx, symbol_mapping=sym_map) | ||
| assert mod.code == ptx | ||
| if not Program._can_load_generated_ptx(): | ||
| if not Program.driver_can_load_nvrtc_ptx_output(): |
Contributor
Author
There was a problem hiding this comment.
This is worthy of discussion. I changed this private API into a public one after refactoring because it seems somewhat useful to an end user. An alternative would be to continue using the private API if the value here is too low.
Andy-Jost
commented
Feb 3, 2026
Comment on lines
+425
to
+442
| class _ProgramMNFF: | ||
| """Members needed for postrm release of program handles.""" | ||
|
|
||
| __slots__ = "handle", "backend" | ||
|
|
||
| def __init__(self, program_obj, handle, backend): | ||
| self.handle = handle | ||
| self.backend = backend | ||
| weakref.finalize(program_obj, self.close) | ||
|
|
||
| def close(self): | ||
| if self.handle is not None: | ||
| if self.backend == "NVRTC": | ||
| handle_return(nvrtc.nvrtcDestroyProgram(self.handle)) | ||
| elif self.backend == "NVVM": | ||
| nvvm = _get_nvvm_module() | ||
| nvvm.destroy_program(self.handle) | ||
| self.handle = None |
Contributor
Author
There was a problem hiding this comment.
I am keeping MNFF and the weakref.finalize cleanup for this PR. In a subsequent PR, I plan to extend the resource handles to nvrtc and nvvm and add nogil blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts
_program.pyto Cython (_program.pyx) for improved code organization and future performance optimization.Programtocdef classwith.pxddeclarationscdef inlinehelpersProgram.driver_can_load_nvrtc_ptx_output()Changes
_program.py→_program.pyxwithcdef class Program_program.pxdwith typed attribute declarations__all__, type alias section added:class:refs and public paths_nvvm_exception_managerinlined (single use)Unionimport removed in favor of|syntaxTest plan
test_program.pytests passtest_module.pytests passpre-commitpassesCloses #1082