fix: Use is_family_of() for SM90 arch guard in warpgroup MmaOp#3084
Open
blake-snc wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: Use is_family_of() for SM90 arch guard in warpgroup MmaOp#3084blake-snc wants to merge 1 commit intoNVIDIA:mainfrom
blake-snc wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Replace hardcoded `arch == Arch.sm_90a` with `arch.is_family_of(Arch.sm_90a)` in warpgroup/mma.py's MmaOp for consistency with the warp-level MMA fix in NVIDIA#3082. While functionally equivalent today (sm_90a is the only Hopper "a"-suffix arch in practice), this makes the arch guard consistent with the is_family_of() pattern and future-proofs against potential Hopper variants. Validated: - is_family_of(Arch.sm_90a) returns True for sm_90a - is_family_of(Arch.sm_90a) returns False for sm_120a, sm_100a Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Ping for review — same |
|
This PR has been labeled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arch == Arch.sm_90awitharch.is_family_of(Arch.sm_90a)inwarpgroup/mma.py'sMmaOp.__post_init__Problem
MmaOpinwarpgroup/mma.pyusesif not arch == Arch.sm_90ato guard its arch check. While functionally correct today (sm_90a is the only Hopper "a"-suffix arch), this is inconsistent with theis_family_of()pattern used elsewhere in CuTe DSL (see #3082 for the SM12x equivalent fix).Fix
Validation
sm_90a accepted, non-Hopper arches correctly rejected.
Related
warp/mma.pyContributed by Second Nature Computing (https://joinsecondnature.com)