Add per-component hostNetwork support for all DaemonSet operands#2246
Open
calmkart wants to merge 1 commit intoNVIDIA:mainfrom
Open
Add per-component hostNetwork support for all DaemonSet operands#2246calmkart wants to merge 1 commit intoNVIDIA:mainfrom
calmkart wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
calmkart
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
Previously, only DCGMExporter supported configuring hostNetwork through the ClusterPolicy CRD. This commit extends hostNetwork support to all remaining DaemonSet components: Driver, VGPUManager, Toolkit, DevicePlugin, SandboxDevicePlugin, KataDevicePlugin, DCGM, NodeStatusExporter, GPUFeatureDiscovery, MIGManager, KataManager, VFIOManager, CCManager, VGPUDeviceManager, and Validator. Each component's Spec type now includes an optional HostNetwork *bool field following the same pattern as DCGMExporterSpec. When enabled, the controller sets hostNetwork: true and DNSPolicy: ClusterFirstWithHostNet on the corresponding DaemonSet pod spec. Changes: - Add HostNetwork field to 15 component Spec types in ClusterPolicy CRD - Add applyHostNetworkConfig helper and call it in 17 Transform functions - Add hostNetwork values and Helm template rendering for all components - Regenerate deepcopy functions and CRD manifests - Add unit tests for applyHostNetworkConfig Signed-off-by: Calm Peng <494296669@qq.com>
calmkart
force-pushed
the
feat/add-hostnetwork-support-for-all-daemonsets
branch
from
bf629bf to
f847562
Compare
Author
|
@cdesiniotis @karthikvetrivel @tariq1890 PTAL, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostNetworksupport for all DaemonSet operands in ClusterPolicy CRDhostNetworkboolean field, following the existing DCGMExporter patternTest plan
applyHostNetworkConfighelper (nil/true/false cases)make generateandmake manifestsrun successfullyDescription
Previously, only DCGMExporter supported configuring hostNetwork through the ClusterPolicy CRD. This commit extends hostNetwork support to all remaining DaemonSet components: Driver, VGPUManager, Toolkit, DevicePlugin, SandboxDevicePlugin, KataDevicePlugin, DCGM, NodeStatusExporter, GPUFeatureDiscovery, MIGManager, KataManager, VFIOManager, CCManager, VGPUDeviceManager, and Validator.
Each component's Spec type now includes an optional HostNetwork *bool field following the same pattern as DCGMExporterSpec. When enabled, the controller sets hostNetwork: true and DNSPolicy: ClusterFirstWithHostNet on the corresponding DaemonSet pod spec.
Changes: