Open
Conversation
…mplete pipeline using EDM model Signed-off-by: Abhijeet Vishwasrao <abvish@vpn10-95.remote-access.kth.se>
Signed-off-by: Abhijeet Vishwasrao <abvish@vpn10-53.remote-access.kth.se>
Signed-off-by: Abhijeet Vishwasrao <abvish@vpn10-53.remote-access.kth.se>
Signed-off-by: Abhijeet Vishwasrao <abvish@vpn10-53.remote-access.kth.se>
Contributor
Greptile OverviewGreptile SummaryAdds complete pipeline for 2D urban turbulent flow generation using EDM diffusion models, including training, generation, and statistical evaluation capabilities. Critical Issues Found:
Strengths:
Recommendations:
Important Files ChangedFile Analysis
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+356
to
+360
| for seed, pred_np in zip(batch_seeds, preds_np): | ||
| image_dir = img_outdir | ||
| os.makedirs(image_dir, exist_ok=True) | ||
| image_path = os.path.join(image_dir, f"{seed:06d}.npy") | ||
| np.save(image_path, pred_np) |
Contributor
There was a problem hiding this comment.
logic: Outputs saved as .npy files but evaluate-uncond-gen-2D.py:44 expects HDF5 format with key 'pred'. This breaks the evaluation pipeline.
Either consolidate individual .npy files into HDF5 after generation, or update evaluation to load from .npy files.
Comment on lines
+300
to
+317
| Generated samples are saved as HDF5 files: | ||
|
|
||
| ```text | ||
| outputs/diffusion_uflow/generated/pred_snaps-<steps>.h5 | ||
| ``` | ||
|
|
||
| **File Structure:** | ||
|
|
||
| ```python | ||
| { | ||
| 'u_pred': (N, 288, 96), # Generated U-velocity | ||
| 'v_pred': (N, 288, 96), # Generated V-velocity | ||
| 'x': (288,), # X-coordinates | ||
| 'y': (96,) # Y-coordinates | ||
| } | ||
| ``` | ||
|
|
||
| Velocities are denormalized to physical units. |
Contributor
There was a problem hiding this comment.
logic: Incorrect output format documented. generate.py saves individual .npy files (line 359-360), not HDF5.
Comment on lines
+1122
to
+1133
| ds_ratio=config.dataset.ds_ratio, | ||
| ) # Check this while integrating the function | ||
| u_pt_p = get_data_for_stats( | ||
| self.pred[:, i], | ||
| x=x, | ||
| y=y, | ||
| z=z, | ||
| input_data_type="2D", | ||
| data="point", | ||
| mean_over_time=False, | ||
| ds_ratio=config.dataset.ds_ratio, | ||
| ) |
Contributor
There was a problem hiding this comment.
logic: config variable undefined - should be self.ds_ratio (used consistently elsewhere in this class)
|
|
||
| # Generation | ||
| - generation/uflow2d | ||
| #- generation/patched_based |
Contributor
There was a problem hiding this comment.
style: Space missing before # comment character
Contributor
|
This pull request is stale because it has been open for 90 days with no activity. Remove the stale label or comment to keep it open, otherwise this will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.