GeoTransolver: Fix attention and turn off feature broadcasting.

[coreyjadams]

PhysicsNeMo Pull Request

Description

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.
• The CHANGELOG.md is up to date with these changes.
• An issue is linked to this pull request.
• If I am implementing a new model or modifying any existing model, I have followed the Models Implementation Coding Standards.

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

[coreyjadams]

Rebased into rc for 2.0.0

[greptile-apps]

Greptile Summary

Fixed critical attention residual connection bug in GeoTransolver and disabled feature broadcasting to match expected tensor shapes.

Key Changes:

• Fixed residual connection in GALE_block.forward() to add attention output to original input fx instead of normalized input normed_inputs (line 460 in gale.py)
• Disabled broadcast_global_features in config to avoid broadcasting scalar global features across all spatial points
• Updated inference script to create scalar tensors with shape () instead of (1,) to match the non-broadcasting mode

Architecture Fix:
The attention fix is critical - the previous code attn[i] + normed_inputs[i] was adding the attention output to the layer-normalized input, which breaks the pre-norm residual architecture. The corrected version attn[i] + fx[i] properly implements: output = Attention(LayerNorm(input)) + input.

Important Files Changed

Filename	Overview
physicsnemo/experimental/models/geotransolver/gale.py	Fixed residual connection bug in GALE_block - now correctly adds attention output to original input fx instead of normalized input normed_inputs
examples/cfd/external_aerodynamics/transformer_models/src/inference_on_vtk.py	Changed scalar parameters from shape (1,) to shape () to match disabled broadcast_global_features mode
examples/cfd/external_aerodynamics/transformer_models/src/conf/geotransolver_surface.yaml	Disabled broadcast_global_features flag to avoid broadcasting scalars across all points

_{Last reviewed commit: 465d9c2}

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[coreyjadams]

/blossom-ci

[coreyjadams]

/blossom-ci