New capability to pull CL events by the millisecond#42
Merged
fatimarahman merged 3 commits intomainfrom Jan 29, 2025
Merged
Conversation
aaronfriedman6
approved these changes
Jan 29, 2025
Contributor
aaronfriedman6
left a comment
aaronfriedman6
left a comment
There was a problem hiding this comment.
Which format do we use when doing regular polling?
Contributor
Author
|
@aaronfriedman6 Right now we poll by the second, but I think I'm going to switch over to millisecond to prevent losing any events |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent missing any library events & to add additional granularity, users should now be able to pull library events by the millisecond. This isn't mentioned in the CL API docs, so users also have the option to pull by the minute or the second.
In addition, the CL API pulls the previous day's events by default, so I've eliminated unnecessary code from the
get_library_eventsmethod.