Skip to content

Fix mutable default arguments in sensor_analysis and clearsky_analysis #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+16 −4
Closed

Fix mutable default arguments in sensor_analysis and clearsky_analysis #489

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d485f0
Initial plan
Copilot Mar 5, 2026
f4f84ce
Fix mutable default arguments in sensor_analysis and clearsky_analysis
Copilot Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions rdtools/analysis_chains.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,7 @@ def _clearsky_preprocess(self):
)

def sensor_analysis(
self, analyses=["yoy_degradation"], yoy_kwargs={"label": "right"}, srr_kwargs={}
self, analyses=None, yoy_kwargs=None, srr_kwargs=None
):
"""
Perform entire sensor-based analysis workflow.
Expand All @@ -1011,7 +1011,7 @@ def sensor_analysis(
---------
analyses : list
Analyses to perform as a list of strings. Valid entries are 'yoy_degradation'
and 'srr_soiling'
and 'srr_soiling'. Defaults to ``["yoy_degradation"]``.
yoy_kwargs : dict
kwargs to pass to :py:func:`rdtools.degradation.degradation_year_on_year`
default is {"label": "right"}, which will right-label the YoY slope values.
Expand All @@ -1022,6 +1022,12 @@ def sensor_analysis(
-------
None
"""
if analyses is None:
analyses = ["yoy_degradation"]
if yoy_kwargs is None:
yoy_kwargs = {"label": "right"}
if srr_kwargs is None:
srr_kwargs = {}
self._sensor_preprocess()
sensor_results = {}

Expand All @@ -1042,7 +1048,7 @@ def sensor_analysis(
self.results["sensor"] = sensor_results

def clearsky_analysis(
self, analyses=["yoy_degradation"], yoy_kwargs={"label": "right"}, srr_kwargs={}
self, analyses=None, yoy_kwargs=None, srr_kwargs=None
):
"""
Perform entire clear-sky-based analysis workflow. Results are stored
Expand All @@ -1052,7 +1058,7 @@ def clearsky_analysis(
---------
analyses : list
Analyses to perform as a list of strings. Valid entries are 'yoy_degradation'
and 'srr_soiling'
and 'srr_soiling'. Defaults to ``["yoy_degradation"]``.
yoy_kwargs : dict
kwargs to pass to :py:func:`rdtools.degradation.degradation_year_on_year`.
default is {"label": "right"}, which will right-label the YoY slope values.
Expand All @@ -1063,6 +1069,12 @@ def clearsky_analysis(
-------
None
"""
if analyses is None:
analyses = ["yoy_degradation"]
if yoy_kwargs is None:
yoy_kwargs = {"label": "right"}
if srr_kwargs is None:
srr_kwargs = {}

self._clearsky_preprocess()
clearsky_results = {}
Expand Down