Add: DiveMode and bailout support to the plan screen ViewModel#127
Merged
Add: DiveMode and bailout support to the plan screen ViewModel#127
Conversation
Added `setDiveMode()` to `DiveEditorViewModelDelegate`, which handles switching between open-circuit and closed-circuit dive modes. Also added a `bailout` parameter to `setContingency()` to allow a bailout closed-circuit plan to be calculated instead a normal closed-circuit dive. Required for: #3
b3e93f1 to
4ca5b5e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 18.09% 18.53% +0.43%
==========================================
Files 134 134
Lines 6780 6831 +51
Branches 753 759 +6
==========================================
+ Hits 1227 1266 +39
- Misses 5460 5472 +12
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
setDiveMode()toDiveEditorViewModelDelegate, which handles switching between open-circuit and closed-circuit dive modes. Also added abailoutparameter tosetContingency()to allow a bailout closed-circuit plan to be calculated instead a normal closed-circuit dive.Required for: #3