Skip to content

Add: DiveMode and bailout support to the plan screen ViewModel#127

Merged
Rolf-Smit merged 1 commit intomainfrom
feature/ccr-dive-mode-switching
Apr 14, 2026
Merged

Add: DiveMode and bailout support to the plan screen ViewModel#127
Rolf-Smit merged 1 commit intomainfrom
feature/ccr-dive-mode-switching

Conversation

@Rolf-Smit
Copy link
Copy Markdown
Contributor

@Rolf-Smit Rolf-Smit commented Apr 14, 2026

Added setDiveMode() to DiveEditorViewModelDelegate, which handles switching between open-circuit and closed-circuit dive modes. Also added a bailout parameter to setContingency() to allow a bailout closed-circuit plan to be calculated instead a normal closed-circuit dive.

Required for: #3

Added `setDiveMode()` to `DiveEditorViewModelDelegate`, which handles switching between open-circuit and closed-circuit dive modes. Also added a `bailout` parameter to `setContingency()` to allow a bailout closed-circuit plan to be calculated instead a normal closed-circuit dive.

Required for: #3
@Rolf-Smit Rolf-Smit force-pushed the feature/ccr-dive-mode-switching branch from b3e93f1 to 4ca5b5e Compare April 14, 2026 14:57
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.52632% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.53%. Comparing base (1c60d05) to head (4ca5b5e).

Files with missing lines Patch % Lines
...ion/screens/planner/DiveEditorViewModelDelegate.kt 71.42% 11 Missing and 3 partials ⚠️
...er/domain/diveplanning/model/DivePlanInputModel.kt 0.00% 5 Missing ⚠️
...ch/app/abysner/presentation/preview/PreviewData.kt 0.00% 4 Missing ⚠️
...p/abysner/domain/diveplanning/model/DivePlanSet.kt 0.00% 3 Missing ⚠️
...resentation/screens/planner/PlanScreenViewModel.kt 84.61% 2 Missing ⚠️
...abysner/presentation/screens/planner/PlanScreen.kt 0.00% 1 Missing ⚠️
...sentation/screens/planner/decoplan/DecoPlanCard.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   18.09%   18.53%   +0.43%     
==========================================
  Files         134      134              
  Lines        6780     6831      +51     
  Branches      753      759       +6     
==========================================
+ Hits         1227     1266      +39     
- Misses       5460     5472      +12     
  Partials       93       93              
Flag Coverage Δ
domain 77.76% <0.00%> (-0.44%) ⬇️
presentation 5.26% <67.64%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rolf-Smit Rolf-Smit merged commit 327f12c into main Apr 14, 2026
4 checks passed
@Rolf-Smit Rolf-Smit deleted the feature/ccr-dive-mode-switching branch April 14, 2026 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants