Fix typos inside TestPopulateConfigurationDefaults_AllSet test#1002
Open
dariakts wants to merge 1 commit intoNetApp:masterfrom
Open
Fix typos inside TestPopulateConfigurationDefaults_AllSet test#1002dariakts wants to merge 1 commit intoNetApp:masterfrom
dariakts wants to merge 1 commit intoNetApp:masterfrom
Conversation
dariakts
force-pushed
the
fix_configdefaults_allset_test_typo
branch
2 times, most recently
from
3006759 to
f519bef
Compare
dariakts
force-pushed
the
fix_configdefaults_allset_test_typo
branch
from
f519bef to
7d482c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Fix typos inside TestPopulateConfigurationDefaults_AllSet test.
Project tracking
N/A
Do any added TODOs have an issue in the backlog?
N/A
Did you add unit tests? Why not?
N/A
Does this code need functional testing?
N/A
Is a code review walkthrough needed? why or why not?
Yes, I'm an external developer, not sure who to ask for review.
Should additional test coverage be executed in addition to pre-merge?
Don't seem to be so.
Does this code need a note in the changelog?
No
Does this code require documentation changes?
No
Additional Information
For
assert.Equal(t, sa.SMB, driver.Config.NASType, "NAS type mismatch")update I assume that what was expected to be tested was settingNASType: "smb",.