Set namespace in commands in chart notes#835
Open
lindhe wants to merge 2 commits intoNetApp:masterfrom
Open
Conversation
Author
|
I see that the chart version number does not seem to align with the version number available from the chart repo. Does that mean that I should not bump the version number manually? I assume it's done by a CI pipeline? |
5ccfdf7 to
94d0bf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
This change explicitly sets the namespace in the commands suggested in the chart's NOTES.txt file, which are rendered upon installation.
Before this change, the namespace was not included so the commands would generally not work without modification.
Did you add unit tests? Why not?
No, this is a trivial change and a change to what basically amounts to documentation, nonetheless.
Does this code need functional testing?
No, but I ran
helm install foo --dry-run .to test it first, and it seems to work as intended.Note: I first had to
kubectl apply -f ./crds/tridentorchestrators.yamlto be able to run thehelm installcommand, even with--dry-run. I think there's no way around that, unfortunately.Is a code review walkthrough needed? why or why not?
Nah, it's a very straight-forward change imo.
Should additional test coverage be executed in addition to pre-merge?
No.
Does this code need a note in the changelog?
No.
Does this code require documentation changes?
No.
Additional Information
I've also bumped the chart version.