Skip to content

Add Roslyn analyzer for event sink helper consistency (NOE001-NOE003) #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jozefizso merged 4 commits into from
Apr 14, 2026
Merged

Add Roslyn analyzer for event sink helper consistency (NOE001-NOE003) #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47a859f
Create a analyzer for issues with event sink helpers
jozefizso Jan 30, 2026
20a01ac
Fix code issues flagged in the analyzer project
jozefizso Apr 9, 2026
8e7e4cb
Rebuild `packages.lock.json`
jozefizso Apr 9, 2026
55b26b3
Enable warnings reporting in event handlers implementations
jozefizso Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Source/ADODB/Events/ConnectionEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.ADODBApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("ADODB", 2.1,2.5)]
Expand Down Expand Up @@ -305,5 +305,5 @@ public void Disconnect([In] object adStatus, [In, MarshalAs(UnmanagedType.IDispa

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/ADODB/Events/RecordsetEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.ADODBApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("ADODB", 2.1,2.5)]
Expand Down Expand Up @@ -350,5 +350,5 @@ public void FetchComplete([In, MarshalAs(UnmanagedType.IDispatch)] object pError

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
14 changes: 14 additions & 0 deletions Source/ADODB/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
"version": 1,
"dependencies": {
".NETFramework,Version=v4.6.2": {
"Microsoft.NETFramework.ReferenceAssemblies": {
"type": "Direct",
"requested": "[1.0.3, )",
"resolved": "1.0.3",
"contentHash": "vUc9Npcs14QsyOD01tnv/m8sQUnGTGOw1BCmKcv77LBJY7OxhJ+zJF7UD/sCL3lYNFuqmQEVlkfS4Quif6FyYg==",
"dependencies": {
"Microsoft.NETFramework.ReferenceAssemblies.net462": "1.0.3"
}
},
"Microsoft.SourceLink.GitHub": {
"type": "Direct",
"requested": "[1.1.1, )",
Expand Down Expand Up @@ -29,6 +38,11 @@
"resolved": "1.1.1",
"contentHash": "AT3HlgTjsqHnWpBHSNeR0KxbLZD7bztlZVj7I8vgeYG9SYqbeFGh0TM/KVtC6fg53nrWHl3VfZFvb5BiQFcY6Q=="
},
"Microsoft.NETFramework.ReferenceAssemblies.net462": {
"type": "Transitive",
"resolved": "1.0.3",
"contentHash": "IzAV30z22ESCeQfxP29oVf4qEo8fBGXLXSU6oacv/9Iqe6PzgHDKCaWfwMBak7bSJQM0F5boXWoZS+kChztRIQ=="
},
"Microsoft.SourceLink.Common": {
"type": "Transitive",
"resolved": "1.1.1",
Expand Down
6 changes: 3 additions & 3 deletions Source/Access/Events/DispAttachmentEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -385,5 +385,5 @@ public void AttachmentCurrent()

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispBoundObjectFrameEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -355,5 +355,5 @@ public void KeyUp([In] [Out] ref object keyCode, [In] [Out] ref object shift)

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispCheckBoxEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -336,5 +336,5 @@ public void KeyUp([In] [Out] ref object keyCode, [In] [Out] ref object shift)

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispChildLabelEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -48,5 +48,5 @@ public DispChildLabelEvents_SinkHelper(ICOMObject eventClass, IConnectionPoint c

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispComboBoxEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -414,5 +414,5 @@ public void Undo([In] [Out] ref object cancel)

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispCommandButtonEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -299,5 +299,5 @@ public void KeyUp([In] [Out] ref object keyCode, [In] [Out] ref object shift)

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispCustomControlEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -132,5 +132,5 @@ public void LostFocus()

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispCustomControlInReportEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -48,5 +48,5 @@ public DispCustomControlInReportEvents_SinkHelper(ICOMObject eventClass, IConnec

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispEmptyCellEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 14,15,16)]
Expand Down Expand Up @@ -48,5 +48,5 @@ public DispEmptyCellEvents_SinkHelper(ICOMObject eventClass, IConnectionPoint co

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispImageEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -169,5 +169,5 @@ public void MouseUp([In] [Out] ref object button, [In] [Out] ref object shift, [

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispLabelEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -169,5 +169,5 @@ public void MouseUp([In] [Out] ref object button, [In] [Out] ref object shift, [

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispLineEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -48,5 +48,5 @@ public DispLineEvents_SinkHelper(ICOMObject eventClass, IConnectionPoint connect

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispListBoxEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -335,5 +335,5 @@ public void KeyUp([In] [Out] ref object keyCode, [In] [Out] ref object shift)

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispNavigationButtonEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 14,15,16)]
Expand Down Expand Up @@ -300,5 +300,5 @@ public void KeyUp([In] [Out] ref object keyCode, [In] [Out] ref object shift)

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispNavigationControlEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 14,15,16)]
Expand Down Expand Up @@ -390,5 +390,5 @@ public void Undo([In] [Out] ref object cancel)

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispObjectFrameEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -254,5 +254,5 @@ public void MouseUp([In] [Out] ref object button, [In] [Out] ref object shift, [

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
6 changes: 3 additions & 3 deletions Source/Access/Events/DispOptionButtonEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

namespace NetOffice.AccessApi.Events
{
#pragma warning disable
#pragma warning disable CS1591

#region SinkPoint Interface

[SupportByVersion("Access", 12,14,15,16)]
Expand Down Expand Up @@ -333,5 +333,5 @@ public void KeyUp([In] [Out] ref object keyCode, [In] [Out] ref object shift)

#endregion

#pragma warning restore
#pragma warning restore CS1591
}
Loading
Loading