Skip to content

Fix incorrect attempt number displayed in dismiss_privacy_modal script#10

Merged
jozefizso merged 2 commits intomainfrom
bugfix/fix-attempts-counter
Mar 24, 2026
Merged

Fix incorrect attempt number displayed in dismiss_privacy_modal script#10
jozefizso merged 2 commits intomainfrom
bugfix/fix-attempts-counter

Conversation

@DominikPalo
Copy link
Copy Markdown
Member

This PR fixes an issue where the attempt number was offset in the console output, causing the first attempt to dismiss the privacy modal to be displayed as 0/20 instead of 1/20 and so on.

image

@jozefizso
Copy link
Copy Markdown
Member

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11f8ec030a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/dismiss_privacy_modal.sh Outdated
@DominikPalo DominikPalo force-pushed the bugfix/fix-attempts-counter branch from 11f8ec0 to 26bb238 Compare February 17, 2026 15:24
@DominikPalo
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@jozefizso
Copy link
Copy Markdown
Member

@codex review :D

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/dismiss_privacy_modal.sh Outdated
Comment thread scripts/dismiss_privacy_modal.sh Outdated
@jozefizso jozefizso merged commit 03c0fb8 into main Mar 24, 2026
8 checks passed
@jozefizso jozefizso added this to the v1.1.0 milestone Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants